[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: kickoff breadcrumb cursor
From: "Marco Martin" <notmart () gmail ! com>
Date: 2011-11-16 20:43:31
Message-ID: 20111116204331.27075.84981 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103159/#review8242
-----------------------------------------------------------
thanks for the patch :)
i think you can do it in a simpler way (see below)
plasma/desktop/applets/kickoff/ui/launcher.cpp
<http://git.reviewboard.kde.org/r/103159/#comment7038>
you don't need to subclass, just button->setCursor(Qt::PointingHandCurs=
or) here
- Marco Martin
On Nov. 16, 2011, 8:36 p.m., Greg T wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103159/
> -----------------------------------------------------------
> =
> (Updated Nov. 16, 2011, 8:36 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> aseigo told me to do it. So what would be the right implementation? ;)
> =
> =
> Diffs
> -----
> =
> plasma/desktop/applets/kickoff/CMakeLists.txt 4b0d32a =
> plasma/desktop/applets/kickoff/ui/breadcrumb.h PRE-CREATION =
> plasma/desktop/applets/kickoff/ui/breadcrumb.cpp PRE-CREATION =
> plasma/desktop/applets/kickoff/ui/launcher.cpp a2acb35 =
> =
> Diff: http://git.reviewboard.kde.org/r/103159/diff/diff
> =
> =
> Testing
> -------
> =
> works very nice
> =
> =
> Thanks,
> =
> Greg T
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103159/">http://git.reviewboard.kde.org/r/103159/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">thanks for the patch :) \
i think you can do it in a simpler way (see below)</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103159/diff/2/?file=41313#file41313line957" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/desktop/applets/kickoff/ui/launcher.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Launcher::fillBreadcrumbs(const QModelIndex &index)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">956</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span \
class="hl">QPushButton</span></span> <span class="o">*</span><span \
class="n">button</span> <span class="o">=</span> <span class="k">new</span> <span \
class="n"><span class="hl">QPushButton</span></span><span class="p">(</span><span \
class="n">d</span><span class="o">-></span><span \
class="n">applicationBreadcrumbs</span><span class="p">);</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">956</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n"><span class="hl">BreadCrumb</span></span> <span class="o">*</span><span \
class="n">button</span> <span class="o">=</span> <span class="k">new</span> <span \
class="n"><span class="hl">BreadCrumb</span></span><span class="p">(</span><span \
class="n">d</span><span class="o">-></span><span \
class="n">applicationBreadcrumbs</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you \
don't need to subclass, just button->setCursor(Qt::PointingHandCursor) \
here</pre> </div>
<br />
<p>- Marco</p>
<br />
<p>On November 16th, 2011, 8:36 p.m., Greg T wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Greg T.</div>
<p style="color: grey;"><i>Updated Nov. 16, 2011, 8:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">aseigo told me to do it. So what would be the right implementation? \
;)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">works very nice</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/kickoff/CMakeLists.txt <span style="color: \
grey">(4b0d32a)</span></li>
<li>plasma/desktop/applets/kickoff/ui/breadcrumb.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/desktop/applets/kickoff/ui/breadcrumb.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/desktop/applets/kickoff/ui/launcher.cpp <span style="color: \
grey">(a2acb35)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103159/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic