[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Don't set Icon if iconName is Empty in ActivityBar
From: "Commit Hook" <null () kde ! org>
Date: 2011-11-16 11:28:16
Message-ID: 20111116112816.12231.36809 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103153/#review8228
-----------------------------------------------------------
This review has been submitted with commit 95c8c4e68674ca4e81616bc99c8f79bc=
75d8a10b by David E. Narv=C3=A1ez to branch master.
- Commit Hook
On Nov. 16, 2011, 5:51 a.m., David Narv=C3=A1ez wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103153/
> -----------------------------------------------------------
> =
> (Updated Nov. 16, 2011, 5:51 a.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> Actually just copying code from ActivityBar::insertContainment(Plasma::Co=
ntainment *cont) where it is already set this way.
> =
> =
> Diffs
> -----
> =
> plasma/generic/applets/activitybar/activitybar.cpp eaefafd =
> =
> Diff: http://git.reviewboard.kde.org/r/103153/diff/diff
> =
> =
> Testing
> -------
> =
> Before this patch, activity names without icon would look a bit flushed r=
ight. After this patch the names look centered properly.
> =
> =
> Thanks,
> =
> David Narv=C3=A1ez
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103153/">http://git.reviewboard.kde.org/r/103153/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 95c8c4e68674ca4e81616bc99c8f79bc75d8a10b by David E. Narváez \
to branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On November 16th, 2011, 5:51 a.m., David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated Nov. 16, 2011, 5:51 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Actually just copying code from \
ActivityBar::insertContainment(Plasma::Containment *cont) where it is already set \
this way.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Before this patch, activity names without icon would look a bit flushed \
right. After this patch the names look centered properly.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/activitybar/activitybar.cpp <span style="color: \
grey">(eaefafd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103153/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic