[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate:now StartPage::createNewProject()
From: "Giorgos Tsiapaliwkas" <terietor () gmail ! com>
Date: 2011-11-14 20:43:14
Message-ID: 20111114204314.4059.93556 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102732/
-----------------------------------------------------------
(Updated Nov. 14, 2011, 8:43 p.m.)
Review request for Plasma.
Changes
-------
I have updated the diff and the plasmateprojectrc files are being created i=
n the right directories.
But the .git folder is not being created in the right dirs.
Also a seg fault occurs during "m_timeLine->loadTimeLine(directory);".
Description
-------
Hello,
for the moment the .plasmateprojectrc file exists as a mark for the project=
s created by plasmate.
We want the file to be created in the creation of the project not in the lo=
ad of the project,the patch does that.
cheers
Diffs (updated)
-----
mainwindow.cpp 6ea7f0c =
startpage.h f16af4b =
startpage.cpp 75052b1 =
Diff: http://git.reviewboard.kde.org/r/102732/diff/diff
Testing
-------
workinig
Thanks,
Giorgos Tsiapaliwkas
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102732/">http://git.reviewboard.kde.org/r/102732/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated Nov. 14, 2011, 8:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have updated the diff and the plasmateprojectrc files are being \
created in the right directories. But the .git folder is not being created in the \
right dirs. Also a seg fault occurs during \
"m_timeLine->loadTimeLine(directory);".</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
for the moment the .plasmateprojectrc file exists as a mark for the projects created \
by plasmate. We want the file to be created in the creation of the project not in the \
load of the project,the patch does that.
cheers</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">workinig</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>mainwindow.cpp <span style="color: grey">(6ea7f0c)</span></li>
<li>startpage.h <span style="color: grey">(f16af4b)</span></li>
<li>startpage.cpp <span style="color: grey">(75052b1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102732/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic