[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate:add a new label at the startpage
From: "Giorgos Tsiapaliwkas" <terietor () gmail ! com>
Date: 2011-11-12 19:29:42
Message-ID: 20111112192942.5003.53018 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102991/
-----------------------------------------------------------
(Updated Nov. 12, 2011, 7:29 p.m.)
Review request for Plasma.
Changes
-------
I updated the diff according to Aaron's observations.
I noticed that plasmate even with this patch that it doesn't handle the cor=
rupted metadata.desktop files.
Do you want me to write another patch for that?(of course it will an other =
review)
thanks
Description
-------
Hi,
in order someone to load a project using the plasmate,he has to give a path=
like this,"$my_plasmoid/$my_plasmoid/contents".
If someone wasn't aware of that he would have an issue.So i add a label whi=
ch will inform the user about that.
thanks in advance
Diffs (updated)
-----
startpage.cpp 329355c =
startpage.ui 942e6ab =
Diff: http://git.reviewboard.kde.org/r/102991/diff/diff
Testing
-------
it's ok
Thanks,
Giorgos Tsiapaliwkas
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102991/">http://git.reviewboard.kde.org/r/102991/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated Nov. 12, 2011, 7:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I updated the diff according to Aaron's observations.
I noticed that plasmate even with this patch that it doesn't handle the corrupted \
metadata.desktop files. Do you want me to write another patch for that?(of course it \
will an other review)
thanks</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi,
in order someone to load a project using the plasmate,he has to give a path like \
this,"$my_plasmoid/$my_plasmoid/contents". If someone wasn't aware of \
that he would have an issue.So i add a label which will inform the user about that.
thanks in advance
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">it's ok </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>startpage.cpp <span style="color: grey">(329355c)</span></li>
<li>startpage.ui <span style="color: grey">(942e6ab)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102991/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic