[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Screen Locker daemon
From: "Oswald Buddenhagen" <ossi () kde ! org>
Date: 2011-11-11 8:53:36
Message-ID: 20111111085336.24279.42054 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103105/#review8125
-----------------------------------------------------------
for now only a quick note from me: i won't give you the "ship it" with such=
a todo list; it completely perverts the idea of feature freeze. but, as co=
olo said long ago "feature freeze only means that everybody gets a bad cons=
cience when submitting features". it's perfectly ok if you submit it three =
days after the deadline if you promise to personally coerce at least two an=
d a half people to do Thorough Testing =E2=84=A2 for you.
fwiw, i'd rename kscreenunlocker to ksld_greet for clarity and consistency =
with kdm. also, ksld is not too well chosen, as it does't naturally associa=
te with anything - kscreenlocker should be fine, no?
- Oswald Buddenhagen
On Nov. 10, 2011, 12:16 p.m., Martin Gr=C3=A4=C3=9Flin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103105/
> -----------------------------------------------------------
> =
> (Updated Nov. 10, 2011, 12:16 p.m.)
> =
> =
> Review request for kwin, Plasma and Oswald Buddenhagen.
> =
> =
> Description
> -------
> =
> Yes I know it's late in the cycle :-) and yes not everything is implement=
ed yet, but I am confident that I get these things finished today or at lea=
st till Beta tagging.
> =
> This is the new screenlocker work as discussed on kcd some time ago.
> =
> The screen locker is split into two parts:
> 1. A daemon (ksld) to just lock the screen and grab input
> 2. An unlock dialog (kscreenunlocker) which is executed as a separate pro=
cess.
> =
> In case the unlocker fails/crashes the screen is still locked by
> the lock daemon.
> =
> In case kscreenunlocker crashes or does not succeed, it gets
> automatically restarted by the daemon.
> =
> Things I still need to do:
> * D-Bus integration
> * Grace time
> * integration of existing screen savers into the QML
> * cleanup KRunner
> * several more things
> =
> =
> Diffs
> -----
> =
> CMakeLists.txt 9fa4c10 =
> screenlocker/CMakeLists.txt PRE-CREATION =
> screenlocker/kcfg/kscreensaversettings.kcfg PRE-CREATION =
> screenlocker/kcfg/kscreensaversettings.kcfgc PRE-CREATION =
> screenlocker/ksld.desktop PRE-CREATION =
> screenlocker/ksldapp.h PRE-CREATION =
> screenlocker/ksldapp.cpp PRE-CREATION =
> screenlocker/lockwindow.h PRE-CREATION =
> screenlocker/lockwindow.cpp PRE-CREATION =
> screenlocker/main.cpp PRE-CREATION =
> screenlocker/unlocker/CMakeLists.txt PRE-CREATION =
> screenlocker/unlocker/main.cpp PRE-CREATION =
> screenlocker/unlocker/qml/lockscreen.qml PRE-CREATION =
> screenlocker/unlocker/unlockapp.h PRE-CREATION =
> screenlocker/unlocker/unlockapp.cpp PRE-CREATION =
> screenlocker/unlocker/unlocker.h PRE-CREATION =
> screenlocker/unlocker/unlocker.cpp PRE-CREATION =
> =
> Diff: http://git.reviewboard.kde.org/r/103105/diff/diff
> =
> =
> Testing
> -------
> =
> * Screen locks
> * Screen stays locked if unlocker crasher
> * unlocker gets restarted
> =
> =
> Thanks,
> =
> Martin Gr=C3=A4=C3=9Flin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103105/">http://git.reviewboard.kde.org/r/103105/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">for now only a quick \
note from me: i won't give you the "ship it" with such a todo list; it \
completely perverts the idea of feature freeze. but, as coolo said long ago \
"feature freeze only means that everybody gets a bad conscience when submitting \
features". it's perfectly ok if you submit it three days after the deadline \
if you promise to personally coerce at least two and a half people to do Thorough \
Testing ™ for you.
fwiw, i'd rename kscreenunlocker to ksld_greet for clarity and consistency with \
kdm. also, ksld is not too well chosen, as it does't naturally associate with \
anything - kscreenlocker should be fine, no?</pre> <br />
<p>- Oswald</p>
<br />
<p>On November 10th, 2011, 12:16 p.m., Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin, Plasma and Oswald Buddenhagen.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2011, 12:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes I know it's late in the cycle :-) and yes not everything is \
implemented yet, but I am confident that I get these things finished today or at \
least till Beta tagging.
This is the new screenlocker work as discussed on kcd some time ago.
The screen locker is split into two parts:
1. A daemon (ksld) to just lock the screen and grab input
2. An unlock dialog (kscreenunlocker) which is executed as a separate process.
In case the unlocker fails/crashes the screen is still locked by
the lock daemon.
In case kscreenunlocker crashes or does not succeed, it gets
automatically restarted by the daemon.
Things I still need to do:
* D-Bus integration
* Grace time
* integration of existing screen savers into the QML
* cleanup KRunner
* several more things</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* Screen locks
* Screen stays locked if unlocker crasher
* unlocker gets restarted</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(9fa4c10)</span></li>
<li>screenlocker/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>screenlocker/kcfg/kscreensaversettings.kcfg <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>screenlocker/kcfg/kscreensaversettings.kcfgc <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>screenlocker/ksld.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>screenlocker/ksldapp.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>screenlocker/ksldapp.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>screenlocker/lockwindow.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>screenlocker/lockwindow.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>screenlocker/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>screenlocker/unlocker/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>screenlocker/unlocker/main.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>screenlocker/unlocker/qml/lockscreen.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>screenlocker/unlocker/unlockapp.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>screenlocker/unlocker/unlockapp.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>screenlocker/unlocker/unlocker.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>screenlocker/unlocker/unlocker.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103105/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic