'Re: Review Request: Add a groupingstrategy to automatically group'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Add a groupingstrategy to automatically group
From:       "Anton Kreuzkamp" <akreuzkamp () web ! de>
Date:       2011-11-10 20:49:31
Message-ID: 20111110204931.9717.61867 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103101/
-----------------------------------------------------------

(Updated Nov. 10, 2011, 8:49 p.m.)

Review request for Plasma.

Changes
-------

corrected Q_PROPERTY

Description
-------

This patch adds a groupingstrategy that groups tasks by their tab group, from kwin's \
window tabbing feature. Most of the code in wintabgroupingstrategy is copied from \
programgroupingstrategy. This patch is based on \
https://git.reviewboard.kde.org/r/103099/ to be included in KDELibs 4.7

This addresses bug 224690.
    http://bugs.kde.org/show_bug.cgi?id=224690

Diffs (updated)
-----

  libs/taskmanager/CMakeLists.txt c3848cf 
  libs/taskmanager/groupmanager.h 760ddf1 
  libs/taskmanager/groupmanager.cpp b66c6fa 
  libs/taskmanager/strategies/wintabgroupingstrategy.h PRE-CREATION 
  libs/taskmanager/strategies/wintabgroupingstrategy.cpp PRE-CREATION 
  libs/taskmanager/task.h aa05176 
  libs/taskmanager/task_x11.cpp 9b7d8cb 

Diff: http://git.reviewboard.kde.org/r/103101/diff/diff

Testing
-------

Tested without problems so far.

Thanks,

Anton Kreuzkamp

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103101/">http://git.reviewboard.kde.org/r/103101/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Anton Kreuzkamp.</div>

<p style="color: grey;"><i>Updated Nov. 10, 2011, 8:49 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">corrected Q_PROPERTY</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds a groupingstrategy that groups tasks by their tab group, \
from kwin&#39;s window tabbing feature. Most of the code in wintabgroupingstrategy is \
copied from programgroupingstrategy. This patch is based on \
https://git.reviewboard.kde.org/r/103099/ to be included in KDELibs 4.7</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested without problems so far.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=224690">224690</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/taskmanager/CMakeLists.txt <span style="color: grey">(c3848cf)</span></li>

 <li>libs/taskmanager/groupmanager.h <span style="color: grey">(760ddf1)</span></li>

 <li>libs/taskmanager/groupmanager.cpp <span style="color: \
grey">(b66c6fa)</span></li>

 <li>libs/taskmanager/strategies/wintabgroupingstrategy.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libs/taskmanager/strategies/wintabgroupingstrategy.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libs/taskmanager/task.h <span style="color: grey">(aa05176)</span></li>

 <li>libs/taskmanager/task_x11.cpp <span style="color: grey">(9b7d8cb)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103101/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 