'Review Request: Drop InvisibleCollectionFetch Fetch Strategy in Favor'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Drop InvisibleCollectionFetch Fetch Strategy in Favor
From:       David_Narváez <david.narvaez () computer ! org>
Date:       2011-11-10 6:12:39
Message-ID: 20111110061239.4266.53029 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103088/
-----------------------------------------------------------

Review request for Plasma and Christian Mollekopf.

Description
-------

As the InvisibleCollectionFetch fetch strategy is currently broken, I implemented a \
suggestion by Christian Mollekopf of working around the issues by flatting the model \
through a KDescendantsProxyModel to fix crashes in Plasma related to calendars.

This addresses bug 279322.
    http://bugs.kde.org/show_bug.cgi?id=279322

Diffs
-----

  plasma/generic/dataengines/calendar/calendarengine.cpp 53f98c0 

Diff: http://git.reviewboard.kde.org/r/103088/diff/diff

Testing
-------

1. Add an iCal resource from the internet
2. Refresh the iCal resource
3. Refresh the iCal resource again if Plasma didn't crash on step 2

Withouth this patch, Plasma crashes when trying to remove an item that has no \
collection in the Calendar Model embedded in the Dataengine.

You should also be able to replicate bug 279322 without this patch and this patch \
should fix the situation described there.

Thanks,

David Narváez

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103088/">http://git.reviewboard.kde.org/r/103088/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Christian Mollekopf.</div>
<div>By David Narváez.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As the InvisibleCollectionFetch fetch strategy is currently broken, I \
implemented a suggestion by Christian Mollekopf of working around the issues by \
flatting the model through a KDescendantsProxyModel to fix crashes in Plasma related \
to calendars.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. Add an iCal resource from the internet 2. Refresh the iCal resource
3. Refresh the iCal resource again if Plasma didn&#39;t crash on step 2

Withouth this patch, Plasma crashes when trying to remove an item that has no \
collection in the Calendar Model embedded in the Dataengine.

You should also be able to replicate bug 279322 without this patch and this patch \
should fix the situation described there.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=279322">279322</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/dataengines/calendar/calendarengine.cpp <span style="color: \
grey">(53f98c0)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103088/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 