'Re: Review Request: TaskManager: Pass GroupManager to'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: TaskManager: Pass GroupManager to
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2011-11-05 9:28:24
Message-ID: 20111105092824.15311.29145 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103050/#review7963
-----------------------------------------------------------

Ship it!

Ship It!

- Aaron J. Seigo

On Nov. 4, 2011, 10:51 p.m., Craig Drummond wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103050/
> -----------------------------------------------------------
> =

> (Updated Nov. 4, 2011, 10:51 p.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Description
> -------
> =

> Pass GroupManager instance into shouldShow - as launcher may not always b=
e in a group.
> =

> When a launcher is activated, LauncherItem::associateItemIfMatches() emit=
s associateChanged() so that it gets hidden. This show() is connected to Gr=
oupManagerPrivate::launcherVisibilityChange(), which in turn calls "rootGro=
ups[currentActivity][currentDesktop]->remove(launcher)" if launcher should =
not be shown. So now, the launcher is removed from the root group - hence i=
s not in any group. Therefore, when GroupManagerPrivate::currentActivityCha=
nged() calls
> LauncherItem::shouldShow(), the launcher has no group - so cannot access =
groupmanager.
> =

> =

> Diffs
> -----
> =

>   libs/taskmanager/groupmanager.cpp 15118f0 =

>   libs/taskmanager/launcheritem.h df65d2f =

>   libs/taskmanager/launcheritem.cpp 4621860 =

> =

> Diff: http://git.reviewboard.kde.org/r/103050/diff/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Craig Drummond
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103050/">http://git.reviewboard.kde.org/r/103050/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Aaron J.</p>

<br />
<p>On November 4th, 2011, 10:51 p.m., Craig Drummond wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Craig Drummond.</div>

<p style="color: grey;"><i>Updated Nov. 4, 2011, 10:51 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Pass GroupManager instance into shouldShow - as launcher may not always \
be in a group.

When a launcher is activated, LauncherItem::associateItemIfMatches() emits \
associateChanged() so that it gets hidden. This show() is connected to \
GroupManagerPrivate::launcherVisibilityChange(), which in turn calls \
&quot;rootGroups[currentActivity][currentDesktop]-&gt;remove(launcher)&quot; if \
launcher should not be shown. So now, the launcher is removed from the root group - \
hence is not in any group. Therefore, when \
GroupManagerPrivate::currentActivityChanged() calls LauncherItem::shouldShow(), the \
launcher has no group - so cannot access groupmanager.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/taskmanager/groupmanager.cpp <span style="color: \
grey">(15118f0)</span></li>

 <li>libs/taskmanager/launcheritem.h <span style="color: grey">(df65d2f)</span></li>

 <li>libs/taskmanager/launcheritem.cpp <span style="color: \
grey">(4621860)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103050/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 