[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: TaskManager: TaskAction changes from IconTasks
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-11-03 7:45:14
Message-ID: 20111103074514.19937.334 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103004/#review7890
-----------------------------------------------------------
Ship it!
great :)
once this and the other patches are in, we can start simplifying the menu s=
o it is more elegant...
- Aaron J. Seigo
On Nov. 2, 2011, 10:46 p.m., Craig Drummond wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103004/
> -----------------------------------------------------------
> =
> (Updated Nov. 2, 2011, 10:46 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> 1. Add NewInstance action to launch a new instance of an application.
> 2. Move toggle launcher action out of advanced menu.
> 3. Don't show application name in 'Show A Launcher' action, as might not =
know the real name at this time (e.g. no desktop file read).
> 4. Add application actions, to be shown at the top of the right-click men=
u. IconTasks uses this to show recent docuents, dock manager menu items, an=
d unity items.
> 5. A ToolTipMenu class is created, so that tooltips may be give for menu =
items. This is so that IconTasks can display the full path of a documents i=
n the recent documents menu.
> 6. Add option to have only basic window controls in menu.
> =
> =
> Diffs
> -----
> =
> libs/taskmanager/taskactions.h 2b5a641 =
> libs/taskmanager/taskactions.cpp 0e6ba8e =
> libs/taskmanager/taskactions_p.h 913966c =
> =
> Diff: http://git.reviewboard.kde.org/r/103004/diff/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Craig Drummond
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103004/">http://git.reviewboard.kde.org/r/103004/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">great :)
once this and the other patches are in, we can start simplifying the menu so it is \
more elegant...</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On November 2nd, 2011, 10:46 p.m., Craig Drummond wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Craig Drummond.</div>
<p style="color: grey;"><i>Updated Nov. 2, 2011, 10:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. Add NewInstance action to launch a new instance of an application. 2. \
Move toggle launcher action out of advanced menu. 3. Don't show application name \
in 'Show A Launcher' action, as might not know the real name at this time \
(e.g. no desktop file read). 4. Add application actions, to be shown at the top of \
the right-click menu. IconTasks uses this to show recent docuents, dock manager menu \
items, and unity items. 5. A ToolTipMenu class is created, so that tooltips may be \
give for menu items. This is so that IconTasks can display the full path of a \
documents in the recent documents menu. 6. Add option to have only basic window \
controls in menu. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/taskmanager/taskactions.h <span style="color: grey">(2b5a641)</span></li>
<li>libs/taskmanager/taskactions.cpp <span style="color: grey">(0e6ba8e)</span></li>
<li>libs/taskmanager/taskactions_p.h <span style="color: grey">(913966c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103004/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic