[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Adjust KDateTimes to Current TimeSpec of the
From: "Sergio Luis Martins" <iamsergio () gmail ! com>
Date: 2011-11-01 19:39:16
Message-ID: 20111101193916.13856.38148 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102997/#review7834
-----------------------------------------------------------
A Calendar object is supposed to mirror what's in akonadi, so we can't change \
Incidence's timezones in there.
I think this should be resolved in the presentation layer, converting to the local \
timezone there ( KSystemTimeZones::local() )
- Sergio Luis Martins
On Oct. 31, 2011, 6:57 a.m., David Narváez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102997/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2011, 6:57 a.m.)
>
>
> Review request for Plasma and Sergio Luis Martins.
>
>
> Description
> -------
>
> Adjust KDateTimes after finding out the type of incidence added. Also adjust \
> KDateTimes after a change in the Calendar TimeSpec.
>
> This addresses bug 279427.
> http://bugs.kde.org/show_bug.cgi?id=279427
>
>
> Diffs
> -----
>
> plasma/generic/dataengines/calendar/akonadi/calendar.cpp cd96954
>
> Diff: http://git.reviewboard.kde.org/r/102997/diff/diff
>
>
> Testing
> -------
>
> 1. Add an event in any timezone distinct from the local timezone (you can do that \
> in KOrganizer) 2. Check the start and end times of the event in the calendar
>
> Not sure how to test changing timezones from Plasma, so proposed patch is based on \
> what I think we should do in such a case.
>
> Thanks,
>
> David Narváez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102997/">http://git.reviewboard.kde.org/r/102997/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A Calendar object is \
supposed to mirror what's in akonadi, so we can't change Incidence's \
timezones in there.
I think this should be resolved in the presentation layer, converting to the local \
timezone there ( KSystemTimeZones::local() )</pre> <br />
<p>- Sergio Luis</p>
<br />
<p>On October 31st, 2011, 6:57 a.m., David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Sergio Luis Martins.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated Oct. 31, 2011, 6:57 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adjust KDateTimes after finding out the type of incidence added. Also \
adjust KDateTimes after a change in the Calendar TimeSpec.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. Add an event in any timezone distinct from the local timezone (you \
can do that in KOrganizer) 2. Check the start and end times of the event in the \
calendar
Not sure how to test changing timezones from Plasma, so proposed patch is based on \
what I think we should do in such a case.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=279427">279427</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/dataengines/calendar/akonadi/calendar.cpp <span style="color: \
grey">(cd96954)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102997/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic