'Re: Review Request: picture frame widget - move to next picture on'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: picture frame widget - move to next picture on
From:       "Commit Hook" <null () kde ! org>
Date:       2011-10-31 10:08:04
Message-ID: 20111031100804.20129.13796 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103001/#review7772
-----------------------------------------------------------

This review has been submitted with commit 2d948694b262444fd938bbb94065ee6e61a43417 \
by Aaron Seigo to branch master.

- Commit Hook

On Oct. 30, 2011, 9:59 p.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103001/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2011, 9:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Now when you delete in slideshow mode a picture (right click, open picture, \
> delete), the frame widget moves on to the next picture without complaining. \
> Possibly my implementation is stupid. 
> 
> This addresses bug 177212.
> http://bugs.kde.org/show_bug.cgi?id=177212
> 
> 
> Diffs
> -----
> 
> applets/frame/picture.h 7fc33b4 
> applets/frame/picture.cpp 57d82ed 
> applets/frame/slideshow.cpp a461244 
> 
> Diff: http://git.reviewboard.kde.org/r/103001/diff/diff
> 
> 
> Testing
> -------
> 
> it compiles
> 
> 
> Thanks,
> 
> Greg T
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103001/">http://git.reviewboard.kde.org/r/103001/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 2d948694b262444fd938bbb94065ee6e61a43417 by Aaron Seigo to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On October 30th, 2011, 9:59 p.m., Greg T wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Greg T.</div>

<p style="color: grey;"><i>Updated Oct. 30, 2011, 9:59 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Now when you delete in slideshow mode a picture (right click, open \
picture, delete), the frame widget moves on to the next picture without complaining. \
Possibly my implementation is stupid.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">it compiles</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=177212">177212</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/frame/picture.h <span style="color: grey">(7fc33b4)</span></li>

 <li>applets/frame/picture.cpp <span style="color: grey">(57d82ed)</span></li>

 <li>applets/frame/slideshow.cpp <span style="color: grey">(a461244)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103001/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 