--===============4643963963717532354== Content-Type: multipart/alternative; boundary="===============1856745013194546789==" --===============1856745013194546789== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102997/ ----------------------------------------------------------- (Updated Oct. 31, 2011, 6:57 a.m.) Review request for Plasma and Sergio Luis Martins. Changes ------- Had to modify the last chunk, the original one didn't compile. On working o= n this, I noticed the notifyIncidenceChanged method had a deprecation notic= e that appeared many commits ago and no explanation of what should be used = now, so I'd like to read opinions on what do do there. I'll be investigatin= g too. Description ------- Adjust KDateTimes after finding out the type of incidence added. Also adjus= t KDateTimes after a change in the Calendar TimeSpec. This addresses bug 279427. http://bugs.kde.org/show_bug.cgi?id=3D279427 Diffs (updated) ----- plasma/generic/dataengines/calendar/akonadi/calendar.cpp cd96954 = Diff: http://git.reviewboard.kde.org/r/102997/diff/diff Testing ------- 1. Add an event in any timezone distinct from the local timezone (you can d= o that in KOrganizer) 2. Check the start and end times of the event in the calendar Not sure how to test changing timezones from Plasma, so proposed patch is b= ased on what I think we should do in such a case. Thanks, David Narv=C3=A1ez --===============1856745013194546789== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102997/

Review request for Plasma and Sergio Luis Martins.
By David Narv=C3=A1ez.

Updated Oct. 31, 2011, 6:57 a.m.

Changes 
Had to modify the last chunk, the original one didn't co=
mpile. On working on this, I noticed the notifyIncidenceChanged method had =
a deprecation notice that appeared many commits ago and no explanation of w=
hat should be used now, so I'd like to read opinions on what do do ther=
e. I'll be investigating too.

Descripti= on 

Adjust KDateTimes after finding out the type of incidence ad=
ded. Also adjust KDateTimes after a change in the Calendar TimeSpec.

Testing <= /h1> 
1. Add an event in any timezone distinct from the local time=
zone (you can do that in KOrganizer)
2. Check the start and end times of the event in the calendar

Not sure how to test changing timezones from Plasma, so proposed patch is b=
ased on what I think we should do in such a case.
Bugs: 279427

Diffs= (updated)

  • plasma/generic/dataengines/calendar/akonadi/calendar.cpp (cd96954)

View Diff
--===============1856745013194546789==-- --===============4643963963717532354== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============4643963963717532354==--