[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: picture frame widget - open potd picture
From: Mark <markg85 () gmail ! com>
Date: 2011-10-30 13:24:39
Message-ID: CAPd6JnFEddrz=rOZWGqQRcHU8MJrba7cXtL=pcsqszo9T5N31Q () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On Fri, Oct 28, 2011 at 5:05 PM, Commit Hook <null@kde.org> wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102817/
>
> This review has been submitted with commit c0360bc3ba5e6b049a6605309dcfc4e78d1b0675 \
> by Aaron Seigo to branch master.
>
> - Commit
>
> On October 28th, 2011, 10:20 a.m., Greg T wrote:
> Review request for Plasma.
> By Greg T.
>
> *Updated Oct. 28, 2011, 10:20 a.m.*
> Description
>
> Hi,
> This fix passes m_currentUrl the correct file path, so the downloaded picture will \
> be opened by the picture viewer (gwenview).
> Testing
>
> Bug fixed.
>
> *Bugs: * 280406 <http://bugs.kde.org/show_bug.cgi?id=280406>
> Diffs
>
> - applets/frame/slideshow.cpp (116c514)
> - dataengines/potd/potd.cpp (f1b9933)
>
> View Diff <http://git.reviewboard.kde.org/r/102817/diff/>
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
/home/kde-devel/kdesrc/kde/kdeplasma-addons/wallpapers/potd/potd.cpp: In
member function ‘void PoTD::dataUpdated(const QString&, const Data&)’:
/home/kde-devel/kdesrc/kde/kdeplasma-addons/wallpapers/potd/potd.cpp:71:53:
error: no matching function for call to ‘PoTD::render(QImage&, QSize)’
/home/kde-devel/kdesrc/kde/kdeplasma-addons/wallpapers/potd/potd.cpp:71:53:
note: candidate is:
/home/kde-devel/kde/include/KDE/Plasma/../../plasma/wallpaper.h:485:14:
note: void Plasma::Wallpaper::render(const QString&, const QSize&,
Plasma::Wallpaper::ResizeMethod, const QColor&)
/home/kde-devel/kde/include/KDE/Plasma/../../plasma/wallpaper.h:485:14:
note: no known conversion for argument 1 from ‘QImage’ to ‘const QString&’
Seems like a few tiny bugs ;)
[Attachment #5 (text/html)]
<div class="gmail_quote">On Fri, Oct 28, 2011 at 5:05 PM, Commit Hook <span \
dir="ltr"><<a href="mailto:null@kde.org">null@kde.org</a>></span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;">
<div>
<div style="font-family:Verdana, Arial, Helvetica, Sans-Serif"><div class="im">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 \
solid"> <tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102817/" \
target="_blank">http://git.reviewboard.kde.org/r/102817/</a> </td>
</tr>
</tbody></table>
<br>
</div><pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">This \
review has been submitted with commit c0360bc3ba5e6b049a6605309dcfc4e78d1b0675 by \
Aaron Seigo to branch master.</pre>
<br>
<p>- Commit</p><div class="im">
<br>
<p>On October 28th, 2011, 10:20 a.m., Greg T wrote:</p>
</div><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-repeat:repeat-x;border:1px black solid"> <tbody><tr>
<td><div class="im">
<div>Review request for Plasma.</div>
<div>By Greg T.</div>
<p style="color:grey"><i>Updated Oct. 28, 2011, 10:20 a.m.</i></p>
</div><h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1><div \
class="im"> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Hi,
This fix passes m_currentUrl the correct file path, so the downloaded picture will \
be opened by the picture viewer (gwenview). </pre> </td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Bug \
fixed.</pre> </td>
</tr>
</tbody></table>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt;margin-top:1.5em">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=280406" target="_blank">280406</a>
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
</div><div class="im"><ul style="margin-left:3em;padding-left:0">
<li>applets/frame/slideshow.cpp <span style="color:grey">(116c514)</span></li>
<li>dataengines/potd/potd.cpp <span style="color:grey">(f1b9933)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102817/diff/" style="margin-left:3em" \
target="_blank">View Diff</a></p>
</div></td>
</tr>
</tbody></table>
</div>
</div>
<br>_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> \
<br></blockquote></div><br><div><div><div>/home/kde-devel/kdesrc/kde/kdeplasma-addons/wallpapers/potd/potd.cpp: \
In member function ‘void PoTD::dataUpdated(const QString&, const \
Data&)’:</div><div>/home/kde-devel/kdesrc/kde/kdeplasma-addons/wallpapers/potd/potd.cpp:71:53: \
error: no matching function for call to ‘PoTD::render(QImage&, QSize)’</div>
<div>/home/kde-devel/kdesrc/kde/kdeplasma-addons/wallpapers/potd/potd.cpp:71:53: \
note: candidate is:</div><div>/home/kde-devel/kde/include/KDE/Plasma/../../plasma/wallpaper.h:485:14: \
note: void Plasma::Wallpaper::render(const QString&, const QSize&, \
Plasma::Wallpaper::ResizeMethod, const QColor&)</div>
<div>/home/kde-devel/kde/include/KDE/Plasma/../../plasma/wallpaper.h:485:14: note: \
no known conversion for argument 1 from ‘QImage’ to ‘const \
QString&’</div></div></div><div><br></div><div>Seems like a few tiny bugs \
;)</div>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic