This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102290/

On October 25th, 2011, 11:02 a.m., Aaron J. Seigo wrote:

editors/editpage.cpp (Diff revision 3)
void EditPage::showTreeContextMenu(const QPoint&)
108
            //TODO: do we need a check if for the selected files????? Write now if i select a file that already exists in the images folder i will not
109
            //be informed.
such a check is necessary indeed .. however, i believe KIO::CopyJob provides this internally already. have you tested this?

On October 30th, 2011, 7:45 a.m., Giorgos Tsiapaliwkas wrote:

i replaced KIO::Overwrite with KIO::HideProgressInfo,and the issue was solved
great :) anything left to do on this patch, or is it now ready to go in?

- Aaron J.


On October 30th, 2011, 7:48 a.m., Giorgos Tsiapaliwkas wrote:

Review request for Plasma and Aaron J. Seigo.
By Giorgos Tsiapaliwkas.

Updated Oct. 30, 2011, 7:48 a.m.

Description

hello,

without this patch a user cannot add an image with plasmate.

reproduce,go to files-images-new,the plasmate will open a text editor instead of a dialog,which(the dialog) is able to open an image.

With the patch a dialog will open asking for an image.

Testing

the patch is not ready yet,i have noted some questions.
Also the plasmate tries to open the image with a text editor.This have to be fixed,but how?Should we make plasmate able to preview images?

In addition,when you add something in the list of files(using the different options provided by the files qdockwidget) it names it as "new".This has to be fixed and the plasmate has to show the real name of the file.(different request,i just want an approval for this patch).

Diffs

  • CMakeLists.txt (f3f32a9)
  • editors/editpage.h (7b5dca3)
  • editors/editpage.cpp (d4b0082)
  • editors/imageviewer/imageviewer.h (e69de29)
  • editors/imageviewer/imageviewer.cpp (e69de29)
  • main.cpp (66a7cd8)
  • mainwindow.h (1b1c2a2)
  • mainwindow.cpp (2fa2742)
  • packagemodel.cpp (8c0907a)

View Diff