This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102290/ |
On October 25th, 2011, 11:02 a.m., Aaron J. Seigo wrote:
editors/editpage.cpp (Diff revision 3) void EditPage::showTreeContextMenu(const QPoint&)108 //TODO: do we need a check if for the selected files????? Write now if i select a file that already exists in the images folder i will not109 //be informed.
such a check is necessary indeed .. however, i believe KIO::CopyJob provides this internally already. have you tested this?On October 30th, 2011, 7:45 a.m., Giorgos Tsiapaliwkas wrote:
i replaced KIO::Overwrite with KIO::HideProgressInfo,and the issue was solved
great :) anything left to do on this patch, or is it now ready to go in?
- Aaron J.
On October 30th, 2011, 7:48 a.m., Giorgos Tsiapaliwkas wrote:
Review request for Plasma and Aaron J. Seigo.
By Giorgos Tsiapaliwkas.
Updated Oct. 30, 2011, 7:48 a.m. Description
Testing
Diffs
|