[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: picture frame widget - open potd picture
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-10-28 12:56:02
Message-ID: 20111028125602.4408.83635 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 28, 2011, 11:05 a.m., Aaron J. Seigo wrote:
> > Ship It!
>
> Greg T wrote:
> cool, but I have no write access...your turn ;)
a few more patches like this one and i'll make sure you have write access ;)
seriously though: if you wish to continue contributing over the longer term (or if \
you end up doing so anyways ;), it's best to get a commit account ..
thanks for the patch, i'll integrate it right now.
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102817/#review7711
-----------------------------------------------------------
On Oct. 28, 2011, 10:20 a.m., Greg T wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102817/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2011, 10:20 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Hi,
> This fix passes m_currentUrl the correct file path, so the downloaded picture will \
> be opened by the picture viewer (gwenview).
>
> This addresses bug 280406.
> http://bugs.kde.org/show_bug.cgi?id=280406
>
>
> Diffs
> -----
>
> applets/frame/slideshow.cpp 116c514
> dataengines/potd/potd.cpp f1b9933
>
> Diff: http://git.reviewboard.kde.org/r/102817/diff/diff
>
>
> Testing
> -------
>
> Bug fixed.
>
>
> Thanks,
>
> Greg T
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102817/">http://git.reviewboard.kde.org/r/102817/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 28th, 2011, 11:05 a.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre> </blockquote>
<p>On October 28th, 2011, 12:43 p.m., <b>Greg T</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">cool, but I have no \
write access...your turn ;)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a few more patches like \
this one and i'll make sure you have write access ;)
seriously though: if you wish to continue contributing over the longer term (or if \
you end up doing so anyways ;), it's best to get a commit account ..
thanks for the patch, i'll integrate it right now.</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On October 28th, 2011, 10:20 a.m., Greg T wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Greg T.</div>
<p style="color: grey;"><i>Updated Oct. 28, 2011, 10:20 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hi, This fix passes m_currentUrl the correct file path, so the \
downloaded picture will be opened by the picture viewer (gwenview). </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Bug fixed.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=280406">280406</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/frame/slideshow.cpp <span style="color: grey">(116c514)</span></li>
<li>dataengines/potd/potd.cpp <span style="color: grey">(f1b9933)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102817/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic