[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: IconTasks taskmanager changes
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2011-10-27 11:55:08
Message-ID: 1971380.xdiGDcCosB () freedom
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Wednesday, October 26, 2011 20:57:32 Craig Drummond wrote:
> Attached is diff of IconTask's 0.8.2 taskmanager against the current
> taskmanager in master.

first: thanks for providing the patch. this is the good news :)

the bad news: it's unreviewable. 2639 lines covering 30 files all in one text 
file .. too cumbersome.

back to good news: we can make it reviewable. :)

here's what i'd like to suggest, let me know if it is workable for you:

* create a branch in kde-workspace for each change set (e.g. one for the 
changes in abstractgroupingstrategy.cpp, one for the changes in 
groupmanager.cpp, etc)

* create review board requests from each branch[1]

* we'll go through them one by one and get them in ASAFP

this will be much faster and much more productive than trying to get through a 
2639 line monster in one chunk, as this way we can work on each actual change 
in git and then when ready just git merge branches over. getting it into git 
and breaking it into separate commits would be necessary anyways, so this is 
very little extra effort in the end.

what do you think?

[1] http://techbase.kde.org/Development/Review_Board

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks

["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]