[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: picture frame widget - reduce polling intervall
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-10-25 11:31:26
Message-ID: 20111025113126.4452.15702 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 25, 2011, 11:23 a.m., Aaron J. Seigo wrote:
> > the fix is in the wrong place; it is actually in the dataengine where t=
his polling interval is set. and it is indeed set to 2 seconds there! witho=
ut changing the potd dataengine, the network traffic and some of the cpu us=
age will persist. so i'm fixing it there. thanks for pointing this issue ou=
t with a patch!
fixed in 59b1fe9
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102816/#review7595
-----------------------------------------------------------
On Oct. 10, 2011, 10:24 a.m., Greg T wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102816/
> -----------------------------------------------------------
> =
> (Updated Oct. 10, 2011, 10:24 a.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> Heya,
> This patch adjusts the potd polling intervall to 120 seconds. Previously =
the frame widget was updating the picture every ~2 seconds which caused qui=
te heavy cpu usage!
> =
> =
> Diffs
> -----
> =
> applets/frame/frame.cpp e5fba08 =
> =
> Diff: http://git.reviewboard.kde.org/r/102816/diff/diff
> =
> =
> Testing
> -------
> =
> good so far
> =
> =
> Thanks,
> =
> Greg T
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102816/">http://git.reviewboard.kde.org/r/102816/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 25th, 2011, 11:23 a.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">the fix is in the wrong place; it is actually in the dataengine where \
this polling interval is set. and it is indeed set to 2 seconds there! without \
changing the potd dataengine, the network traffic and some of the cpu usage will \
persist. so i'm fixing it there. thanks for pointing this issue out with a \
patch!</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">fixed in 59b1fe9</pre> \
<br />
<p>- Aaron J.</p>
<br />
<p>On October 10th, 2011, 10:24 a.m., Greg T wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Greg T.</div>
<p style="color: grey;"><i>Updated Oct. 10, 2011, 10:24 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Heya, This patch adjusts the potd polling intervall to 120 seconds. \
Previously the frame widget was updating the picture every ~2 seconds which caused \
quite heavy cpu usage!</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">good so far</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/frame/frame.cpp <span style="color: grey">(e5fba08)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102816/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic