[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate: Metadata is now able to detect the
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-10-25 11:08:01
Message-ID: 20111025110801.3280.82997 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102609/#review7594
-----------------------------------------------------------
Ship it!
mainwindow.cpp
<http://git.reviewboard.kde.org/r/102609/#comment6587>
please watch the indentation :)
- Aaron J. Seigo
On Oct. 21, 2011, 7:30 p.m., Antonis Tsiapaliokas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102609/
> -----------------------------------------------------------
> =
> (Updated Oct. 21, 2011, 7:30 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> Hello
> =
> In the toolbar files, there is a menu with name metadata, which is respon=
sible to retrieve/write some information to the metadata.desktop file. Writ=
e now the plasmate cannot detect the correct api. This patch is fixing th=
is issue.
> =
> =
> Diffs
> -----
> =
> editors/metadata/metadata.ui 454643e =
> editors/metadata/metadataeditor.h f0ae30c =
> editors/metadata/metadataeditor.cpp 2b9f89c =
> mainwindow.h 1b1c2a2 =
> mainwindow.cpp 2fa2742 =
> startpage.h 5a4a5c8 =
> startpage.cpp fc00441 =
> =
> Diff: http://git.reviewboard.kde.org/r/102609/diff/diff
> =
> =
> Testing
> -------
> =
> Plasmate compiles fines.
> The only thing that has been left, is to add "the correct" QLabel to meta=
data menu.
> =
> =
> Thanks,
> =
> Antonis Tsiapaliokas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102609/">http://git.reviewboard.kde.org/r/102609/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/102609/diff/3/?file=39476#file39476line385" \
style="color: black; font-weight: bold; text-decoration: \
underline;">mainwindow.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
MainWindow::saveEditorData()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">385</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span> <span class="n">connect</span><span class="p">(</span><span \
class="n">m_metaEditor</span><span class="p">,</span> <span \
class="n">SIGNAL</span><span class="p">(</span><span class="n">apiChanged</span><span \
class="p">()),</span> <span class="n">SLOT</span><span class="p">(</span><span \
class="n">checkProjectrc</span><span class="p">()));</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">386</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">please \
watch the indentation :)</pre> </div>
<br />
<p>- Aaron J.</p>
<br />
<p>On October 21st, 2011, 7:30 p.m., Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Oct. 21, 2011, 7:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello
In the toolbar files, there is a menu with name metadata, which is responsible to \
retrieve/write some information to the metadata.desktop file. Write now the plasmate \
cannot detect the correct api. This patch is fixing this issue.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Plasmate compiles fines. The only thing that has been left, is to add \
"the correct" QLabel to metadata menu.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>editors/metadata/metadata.ui <span style="color: grey">(454643e)</span></li>
<li>editors/metadata/metadataeditor.h <span style="color: \
grey">(f0ae30c)</span></li>
<li>editors/metadata/metadataeditor.cpp <span style="color: \
grey">(2b9f89c)</span></li>
<li>mainwindow.h <span style="color: grey">(1b1c2a2)</span></li>
<li>mainwindow.cpp <span style="color: grey">(2fa2742)</span></li>
<li>startpage.h <span style="color: grey">(5a4a5c8)</span></li>
<li>startpage.cpp <span style="color: grey">(fc00441)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102609/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic