[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Workaround Taskbar ghost entries bug
From: John Stanley <jpsinthemix () verizon ! net>
Date: 2011-10-14 9:19:09
Message-ID: 4E97FE8D.3020707 () verizon ! net
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi,
I submitted a patch which hopefully fixes Bug
https://bugs.kde.org/show_bug.cgi?id=275469),
which may be related to this issue (see Comment #50). The patch is
short, so here it is:
--- kde-workspace-4.7.2.old/libs/taskmanager/taskitem.cpp
2011-05-20 16:32:08.000000000 -0400
+++ kde-workspace-4.7.2.new/libs/taskmanager/taskitem.cpp
2011-10-14 02:23:33.473139259 -0400
@@ -69,7 +69,6 @@ TaskItem::TaskItem(QObject *parent, Star
TaskItem::~TaskItem()
{
- emit destroyed(this);
//kDebug();
/* if (parentGroup()){
parentGroup()->remove(this);
@@ -99,7 +98,7 @@ void TaskItem::setTaskPointer(TaskPtr ta
d->task = task.data();
connect(task.data(), SIGNAL(changed(::TaskManager::TaskChanges)),
this, SIGNAL(changed(::TaskManager::TaskChanges)));
- connect(task.data(), SIGNAL(destroyed()), this,
SLOT(deleteLater()));
+ connect(task.data(), SIGNAL(destroyed(QObject*)), this,
SLOT(taskDestroyed()));
emit gotTaskPointer();
}
}
[Attachment #5 (text/html)]
<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<font size="-1">Hi,<br>
I submitted a patch which hopefully fixes Bug
<a class="moz-txt-link-freetext" \
href="https://bugs.kde.org/show_bug.cgi?id=275469">https://bugs.kde.org/show_bug.cgi?id=275469</a>),<br>
which may be related to this issue (see Comment #50). The patch is
short, so here it is:<br>
<br>
--- kde-workspace-4.7.2.old/libs/taskmanager/taskitem.cpp
2011-05-20 16:32:08.000000000 -0400<br>
+++ kde-workspace-4.7.2.new/libs/taskmanager/taskitem.cpp
2011-10-14 02:23:33.473139259 -0400<br>
@@ -69,7 +69,6 @@ TaskItem::TaskItem(QObject *parent, Star<br>
<br>
TaskItem::~TaskItem()<br>
{<br>
- emit destroyed(this);<br>
//kDebug();<br>
/* if (parentGroup()){<br>
\
parentGroup()->remove(this);<br> @@ -99,7 +98,7 @@ void \
TaskItem::setTaskPointer(TaskPtr ta<br>
d->task = task.data();<br>
connect(task.data(),
SIGNAL(changed(::TaskManager::TaskChanges)),<br>
\
this, SIGNAL(changed(::TaskManager::TaskChanges)));<br>
- connect(task.data(), \
SIGNAL(destroyed()), this, SLOT(deleteLater()));<br>
+ connect(task.data(), \
SIGNAL(destroyed(QObject*)), this, SLOT(taskDestroyed()));<br>
emit gotTaskPointer();<br>
}<br>
}<br>
<br>
<br>
</font>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic