'Review Request: Add option to not show popup when devices are added'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Add option to not show popup when devices are added
From:       "Simon Persson" <simonpersson1 () gmail ! com>
Date:       2011-10-11 13:30:38
Message-ID: 20111011133038.11268.89019 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102825/
-----------------------------------------------------------

Review request for Plasma, Giulio Camuffo and Jacopo De Simoi.

Summary (updated)
-----------------

Add option to not show popup when devices are added

Description (updated)
-------

Use case:
User 1 frequently connects her phone to her laptop to charge the battery, s=
he has no intention of accessing files on the phone and thinks the device n=
otifier popping up (even for a few seconds) is distracting. When accessing =
files on an external drive she usually uses an already running instance of =
her file manager and again would prefer the notifier to not pop up. She kee=
ps the notifier in her panel for the case of easily watching dvd's and down=
loading photos from a camera memory card. In those cases she thinks it's en=
ough that the icon appears with an exclamation mark in her systray, she can=
 find it there.

Diffs (updated)
-----

  plasma/generic/applets/devicenotifier/configurationpage.ui a916254 =

  plasma/generic/applets/devicenotifier/devicenotifier.h 9f3af73 =

  plasma/generic/applets/devicenotifier/devicenotifier.cpp b9dfce5 =

Diff: http://git.reviewboard.kde.org/r/102825/diff/diff

Testing
-------

Thanks,

Simon Persson

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102825/">http://git.reviewboard.kde.org/r/102825/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Giulio Camuffo and Jacopo De Simoi.</div>
<div>By Simon Persson.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Summary \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add option to not show popup when devices are added</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use case: User 1 frequently connects her phone to her laptop to charge \
the battery, she has no intention of accessing files on the phone and thinks the \
device notifier popping up (even for a few seconds) is distracting. When accessing \
files on an external drive she usually uses an already running instance of her file \
manager and again would prefer the notifier to not pop up. She keeps the notifier in \
her panel for the case of easily watching dvd&#39;s and downloading photos from a \
camera memory card. In those cases she thinks it&#39;s enough that the icon appears \
with an exclamation mark in her systray, she can find it there.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/devicenotifier/configurationpage.ui <span style="color: \
grey">(a916254)</span></li>

 <li>plasma/generic/applets/devicenotifier/devicenotifier.h <span style="color: \
grey">(9f3af73)</span></li>

 <li>plasma/generic/applets/devicenotifier/devicenotifier.cpp <span style="color: \
grey">(b9dfce5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102825/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 