[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Workaround Taskbar ghost entries bug
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2011-10-05 20:03:39
Message-ID: 2236978.T9uizofFfZ () freedom
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Wednesday, October 5, 2011 20:08:55 Craig Drummond wrote:
> I don't know if its related, but whilst working on IconTasks I noticed that
> items set to be deleted via deleteLater (in TaskGroupItem::itemRemoved and
> TaskManager::TaskItem) were not being deleted until after the app
> (plasmoidviewer / plasma-desktop) had terminated.

the only way deleteLater() will not delete is if the event loop is never 
entered. so i'm very suspicious about this claim; perhaps it looked like this 
is what was happening .. but i doubt that is what was happening, at least as 
described here ... 

however, if indeed, items are not getting deleted until app termination, that 
would _certainly_ explain the situations we're seeing.

> To trace this I put debug
> when deleteLater was called, and then in the destructor. I have checked with

are you sure it was the same object (e.g. same address in memory?), and not 
just a task item with, e.g., the same name?

> I worked-around this by using a single-shot QTimer to call deleteLater() -
> but this seems a little hacky to me.

can you share the patch that does this so i can see what is going on first-
hand? thanks! :)

> p.s. I also noticed a bug with AbstractTaskItem::setGeometry(). If the
> passed in geometry is the same as the current geometry, the layout
> animation and update-geometry timers need to be stopped. Otherwise a gap
> can appear when a group of items is closed all at once.

patches very much welcome for these kinds of issues :)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks

["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]