[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Workaround Taskbar ghost entries bug
From: "Commit Hook" <null () kde ! org>
Date: 2011-10-05 11:15:45
Message-ID: 20111005111545.14917.11082 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102779/#review7114
-----------------------------------------------------------
This review has been submitted with commit 681e1ef4b5f0f7e66d3333fa080badaa=
f9a7bac7 by Alex Fiestas to branch KDE/4.7.
- Commit Hook
On Oct. 5, 2011, 9:26 a.m., Alex Fiestas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102779/
> -----------------------------------------------------------
> =
> (Updated Oct. 5, 2011, 9:26 a.m.)
> =
> =
> Review request for Plasma and Aaron J. Seigo.
> =
> =
> Description
> -------
> =
> Well, as some of you may know I have been tracking down the ghost entries=
bug... this time I have NOT been able to fix the source of the problem but=
at least after some GDB at BDS I think I have a workaround.
> =
> A Ghost entry happens when a TaskItem is not either a startup or a task, =
in that case the code that "paints" the task doesn't know what to do but it=
reserve the space anyway.
> Currently the code path is like this:
> 1-TaskGruopItem::itemAdded is called
> 2-It calles TaskGruopItem::createAbstractItem
> 3-createAbstractItem takes a GroupableItem and cast it either to a GroupI=
tem, or LauncherItem or TaskItem depending on the ::itemTtype()
> =
> createAbstractItem is prepared to return 0 when an AbstractTaskItem can't=
be created, and even further WindowTaskItem::setTask is checking if the ta=
skItem is not a startup or a task, the problem is that setTask returns void=
so we can't really know if the "setting" was succeed or not. In that case,=
an "empty" WindowTaskItem is returned, being it a ghost entry.
> =
> This workaround what does is check if the taskItem is valid, if it is not=
0 is returned.
> =
> This is a workaround since, in theory a TaskItem should ALWAYS be either =
a startup or a task so we should find the root of the problem instead of ad=
ding yet another check. Is precisely this kind of checks that make all *tas=
ks* stack a mess.
> =
> =
> Diffs
> -----
> =
> plasma/desktop/applets/tasks/taskgroupitem.cpp eec27c2 =
> =
> Diff: http://git.reviewboard.kde.org/r/102779/diff/diff
> =
> =
> Testing
> -------
> =
> I have been using the patch for 3 days playing around with activities and=
virtual desktops, so far so good.
> =
> =
> Thanks,
> =
> Alex Fiestas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102779/">http://git.reviewboard.kde.org/r/102779/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 681e1ef4b5f0f7e66d3333fa080badaaf9a7bac7 by Alex Fiestas to \
branch KDE/4.7.</pre> <br />
<p>- Commit</p>
<br />
<p>On October 5th, 2011, 9:26 a.m., Alex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Alex Fiestas.</div>
<p style="color: grey;"><i>Updated Oct. 5, 2011, 9:26 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Well, as some of you may know I have been tracking down the ghost \
entries bug... this time I have NOT been able to fix the source of the problem but at \
least after some GDB at BDS I think I have a workaround.
A Ghost entry happens when a TaskItem is not either a startup or a task, in that case \
the code that "paints" the task doesn't know what to do but it reserve \
the space anyway. Currently the code path is like this:
1-TaskGruopItem::itemAdded is called
2-It calles TaskGruopItem::createAbstractItem
3-createAbstractItem takes a GroupableItem and cast it either to a GroupItem, or \
LauncherItem or TaskItem depending on the ::itemTtype()
createAbstractItem is prepared to return 0 when an AbstractTaskItem can't be \
created, and even further WindowTaskItem::setTask is checking if the taskItem is not \
a startup or a task, the problem is that setTask returns void so we can't really \
know if the "setting" was succeed or not. In that case, an \
"empty" WindowTaskItem is returned, being it a ghost entry.
This workaround what does is check if the taskItem is valid, if it is not 0 is \
returned.
This is a workaround since, in theory a TaskItem should ALWAYS be either a startup or \
a task so we should find the root of the problem instead of adding yet another check. \
Is precisely this kind of checks that make all *tasks* stack a mess. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have been using the patch for 3 days playing around with activities \
and virtual desktops, so far so good.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/tasks/taskgroupitem.cpp <span style="color: \
grey">(eec27c2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102779/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic