[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Add an Inhibit button to the Battery applet
From: "Dario Freddi" <drf () kde ! org>
Date: 2011-10-03 14:57:02
Message-ID: 20111003145702.16470.90266 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 3, 2011, 1:19 p.m., Aaron J. Seigo wrote:
> > i like the direction of this towards simplicity, predictability and "making good \
> > decisions in the software" ..
thanks :)
> On Oct. 3, 2011, 1:19 p.m., Aaron J. Seigo wrote:
> > plasma/generic/applets/battery/battery.cpp, line 540
> > <http://git.reviewboard.kde.org/r/102757/diff/2/?file=37818#file37818line540>
> >
> > I'd personally make it "Power management enabled:" as this follows the pattern of \
> > the rest of the items which start with a noun and allows one to scan the left \
> > side quickly: battery, ac, time, power management, screen brightness. "Enabled" \
> > as a first word doesn't tell us much ("what is enabled?")
Good call. Will fix that in my branch.
- Dario
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102757/#review7033
-----------------------------------------------------------
On Oct. 3, 2011, 12:28 p.m., Dario Freddi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102757/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2011, 12:28 p.m.)
>
>
> Review request for Plasma and Sebastian Kügler.
>
>
> Description
> -------
>
> As the title says. The feature works, but I'm wondering if we can make it look \
> better. Any suggestions warmly appreciated :)
>
> Diffs
> -----
>
> plasma/generic/applets/battery/battery.h d696014
> plasma/generic/applets/battery/battery.cpp c3a4f58
>
> Diff: http://git.reviewboard.kde.org/r/102757/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dario Freddi
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102757/">http://git.reviewboard.kde.org/r/102757/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 3rd, 2011, 1:19 p.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">i like the direction of this towards simplicity, predictability and \
"making good decisions in the software" .. </pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">thanks :)</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 3rd, 2011, 1:19 p.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/102757/diff/2/?file=37818#file37818line540" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/battery/battery.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Battery::initPopupWidget()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">538</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_inhibitLabel</span><span class="o">-></span><span \
class="n">setText</span><span class="p">(</span><span class="n">i18nc</span><span \
class="p">(</span><span class="s">"Label for power management \
inhibition"</span><span class="p">,</span> <span class="s">"Enable power \
management:"</span><span class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd personally make \
it "Power management enabled:" as this follows the pattern of the rest of \
the items which start with a noun and allows one to scan the left side quickly: \
battery, ac, time, power management, screen brightness. "Enabled" as a \
first word doesn't tell us much ("what is enabled?")</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good call. \
Will fix that in my branch.</pre> <br />
<p>- Dario</p>
<br />
<p>On October 3rd, 2011, 12:28 p.m., Dario Freddi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Sebastian Kügler.</div>
<div>By Dario Freddi.</div>
<p style="color: grey;"><i>Updated Oct. 3, 2011, 12:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As the title says. The feature works, but I'm wondering if we can \
make it look better. Any suggestions warmly appreciated :)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/battery/battery.h <span style="color: \
grey">(d696014)</span></li>
<li>plasma/generic/applets/battery/battery.cpp <span style="color: \
grey">(c3a4f58)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102757/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic