[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: quicklaunch: Add a confirmation dialog before the
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-09-30 13:40:49
Message-ID: 20110930134049.29791.15842 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Sept. 29, 2011, 11:55 a.m., Sebastian Kügler wrote:
> > First, this is the wrong way to fix it. Why should this confirmation only go for \
> > a specific widget? This introduces inconsistence in the UI that leads to more \
> > data loss (the next time a user deletes a widget, she'll expect there to be a \
> > confirmation, and there won't).
> > Adding a modal dialog is a no-go as well, it blocks the UI and causes general \
> > nastiness.
> > The correct solution against data loss bugs is not to add confirmation dialogs, \
> > but to make the action less destructive, for example by adding a way to undo the \
> > delete.
>
> Antonis Tsiapaliokas wrote:
> When you say "widgets", do you mean only the widgets from the taskmanager or in \
> general (including the desktop)... Because if you mean general, then, do we need to \
> change the kdelibs/plasma???
> Aaron J. Seigo wrote:
> yes, in general. and yes, it would mean making some changes in libplasma: on \
> deleting an applet, the configuration for the applet would need to be moved to some \
> where else e.g. in to a KConfigGroup within the application's configuration, aka \
> KGlobal::config(). this would move it from -appletsrc and could then be used to \
> create an undo mechanism.
alternatively, this could be stored in an in-memory config object could be used for \
this (via KConfig(QString(), KConfig::SimpleConfig)) which would mean it wouldn't \
cause disk i/o or need to be cleared after reboots. it could also be limited in the # \
of items it stores (or limited to a given amount of time) to keep long-running \
instances from ever-inflating in size.
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102727/#review6906
-----------------------------------------------------------
On Sept. 28, 2011, 8:44 p.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102727/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2011, 8:44 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Hello,
>
> This patch is adding a new feature to the quicklaunch plasmaoid.
>
>
> This addresses bug 270105.
> http://bugs.kde.org/show_bug.cgi?id=270105
>
>
> Diffs
> -----
>
> plasma/generic/applets/quicklaunch/quicklaunch.cpp dfc6125
>
> Diff: http://git.reviewboard.kde.org/r/102727/diff/diff
>
>
> Testing
> -------
>
> kde-workspace compiles fine.
>
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102727/">http://git.reviewboard.kde.org/r/102727/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 29th, 2011, 11:55 a.m., <b>Sebastian \
Kügler</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">First, this is the wrong way to fix it. Why should this confirmation \
only go for a specific widget? This introduces inconsistence in the UI that leads to \
more data loss (the next time a user deletes a widget, she'll expect there to be \
a confirmation, and there won't).
Adding a modal dialog is a no-go as well, it blocks the UI and causes general \
nastiness.
The correct solution against data loss bugs is not to add confirmation dialogs, but \
to make the action less destructive, for example by adding a way to undo the \
delete.</pre> </blockquote>
<p>On September 29th, 2011, 1:22 p.m., <b>Antonis Tsiapaliokas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When you say \
"widgets", do you mean only the widgets from the taskmanager or in general \
(including the desktop)... Because if you mean general, then, do we need to change \
the kdelibs/plasma??? </pre> </blockquote>
<p>On September 30th, 2011, 7:01 a.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, in general. and \
yes, it would mean making some changes in libplasma: on deleting an applet, the \
configuration for the applet would need to be moved to some where else e.g. in to a \
KConfigGroup within the application's configuration, aka KGlobal::config(). this \
would move it from -appletsrc and could then be used to create an undo \
mechanism.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">alternatively, this \
could be stored in an in-memory config object could be used for this (via \
KConfig(QString(), KConfig::SimpleConfig)) which would mean it wouldn't cause \
disk i/o or need to be cleared after reboots. it could also be limited in the # of \
items it stores (or limited to a given amount of time) to keep long-running instances \
from ever-inflating in size.</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On September 28th, 2011, 8:44 p.m., Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Sept. 28, 2011, 8:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
This patch is adding a new feature to the quicklaunch plasmaoid.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kde-workspace compiles fine.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=270105">270105</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/quicklaunch/quicklaunch.cpp <span style="color: \
grey">(dfc6125)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102727/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic