--===============9046418615943284156== Content-Type: multipart/alternative; boundary="===============8604520292490789349==" --===============8604520292490789349== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102732/#review6960 ----------------------------------------------------------- startpage.cpp this should remain, so that opening a project that doesn't have the rc = file gets one. best might be to move this code into a method called somethi= ng like "ensureProjectrcFileExists()" and then call it from both of these p= laces. - Aaron J. Seigo On Sept. 29, 2011, 8:51 a.m., Giorgos Tsiapaliwkas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102732/ > ----------------------------------------------------------- > = > (Updated Sept. 29, 2011, 8:51 a.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > Hello, > = > for the moment the .plasmateprojectrc file exists as a mark for the proje= cts created by plasmate. > We want the file to be created in the creation of the project not in the = load of the project,the patch does that. > = > cheers > = > = > Diffs > ----- > = > startpage.cpp fc00441 = > = > Diff: http://git.reviewboard.kde.org/r/102732/diff/diff > = > = > Testing > ------- > = > workinig > = > = > Thanks, > = > Giorgos Tsiapaliwkas > = > --===============8604520292490789349== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102732/

= =
startpage.cpp (Diff revision 1)
void StartPage::loadLocalProject()
550
    if (!QFile::exists(path + '/' + PROJECTR=
C)) {
551
        QFile rcfile(path + '/' + PROJECTRC)=
;
552
        rcfile.open(<=
span class=3D"n">QIODevice::ReadWrite);
553
        rcfile.close();
554
    }
555
this should remain, so that opening a project that doesn't have =
the rc file gets one. best might be to move this code into a method called =
something like "ensureProjectrcFileExists()" and then call it fro=
m both of these places.

- Aaron J.


On September 29th, 2011, 8:51 a.m., Giorgos Tsiapaliwkas wrote:

Review request for Plasma.
By Giorgos Tsiapaliwkas.

Updated Sept. 29, 2011, 8:51 a.m.

Descripti= on

Hello,

for the moment the .plasmateprojectrc file exists as a mark for the project=
s created by plasmate.
We want the file to be created in the creation of the project not in the lo=
ad of the project,the patch does that.

cheers

Testing <= /h1>
workinig

Diffs=

  • startpage.cpp (fc00441)

View Diff

--===============8604520292490789349==-- --===============9046418615943284156== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============9046418615943284156==--