'Re: Review Request: kde-runtime:fix the coding style of'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: kde-runtime:fix the coding style of
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2011-09-30 12:15:37
Message-ID: 20110930121537.20278.34000 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102684/#review6953
-----------------------------------------------------------

Ship it!

Ship It!

- Aaron J. Seigo

On Sept. 27, 2011, 9:42 a.m., Giorgos Tsiapaliwkas wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102684/
> -----------------------------------------------------------
> =

> (Updated Sept. 27, 2011, 9:42 a.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Description
> -------
> =

> Hello,
> =

> at kde-runtime/plasma/declarativeimports/plasmacomponents the coding styl=
e is not the plasma one.
> This patch fixes the coding style.
> =

> =

> Diffs
> -----
> =

>   plasma/declarativeimports/plasmacomponents/qml/Highlight.qml 9670c28 =

>   plasma/declarativeimports/plasmacomponents/qml/ScrollBar.qml 8adc8b6 =

>   plasma/declarativeimports/plasmacomponents/qml/Button.qml 48bb717 =

>   plasma/declarativeimports/plasmacomponents/qml/ButtonGroup.js ea8ca74 =

>   plasma/declarativeimports/plasmacomponents/qml/ScrollDecorator.qml 5ef6=
638 =

>   plasma/declarativeimports/plasmacomponents/qml/Slider.qml 1931abf =

>   plasma/declarativeimports/plasmacomponents/qml/TextArea.qml f3a7a34 =

>   plasma/declarativeimports/plasmacomponents/qml/TextField.qml beaa681 =

> =

> Diff: http://git.reviewboard.kde.org/r/102684/diff/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Giorgos Tsiapaliwkas
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102684/">http://git.reviewboard.kde.org/r/102684/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Aaron J.</p>

<br />
<p>On September 27th, 2011, 9:42 a.m., Giorgos Tsiapaliwkas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>

<p style="color: grey;"><i>Updated Sept. 27, 2011, 9:42 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,

at kde-runtime/plasma/declarativeimports/plasmacomponents the coding style is not the \
plasma one. This patch fixes the coding style.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/declarativeimports/plasmacomponents/qml/Highlight.qml <span style="color: \
grey">(9670c28)</span></li>

 <li>plasma/declarativeimports/plasmacomponents/qml/ScrollBar.qml <span style="color: \
grey">(8adc8b6)</span></li>

 <li>plasma/declarativeimports/plasmacomponents/qml/Button.qml <span style="color: \
grey">(48bb717)</span></li>

 <li>plasma/declarativeimports/plasmacomponents/qml/ButtonGroup.js <span \
style="color: grey">(ea8ca74)</span></li>

 <li>plasma/declarativeimports/plasmacomponents/qml/ScrollDecorator.qml <span \
style="color: grey">(5ef6638)</span></li>

 <li>plasma/declarativeimports/plasmacomponents/qml/Slider.qml <span style="color: \
grey">(1931abf)</span></li>

 <li>plasma/declarativeimports/plasmacomponents/qml/TextArea.qml <span style="color: \
grey">(f3a7a34)</span></li>

 <li>plasma/declarativeimports/plasmacomponents/qml/TextField.qml <span style="color: \
grey">(beaa681)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102684/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 