From kde-panel-devel Fri Sep 30 12:03:59 2011 From: "Aaron J. Seigo" Date: Fri, 30 Sep 2011 12:03:59 +0000 To: kde-panel-devel Subject: Re: Review Request: Plasmate:add a destructor and some changes to the Message-Id: <20110930120359.19734.87220 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=131738426226564 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8040795115925397665==" --===============8040795115925397665== Content-Type: multipart/alternative; boundary="===============7723719746357362663==" --===============7723719746357362663== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101916/#review6951 ----------------------------------------------------------- Ship it! Ship It! - Aaron J. Seigo On Sept. 23, 2011, 4:20 p.m., Giorgos Tsiapaliwkas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101916/ > ----------------------------------------------------------- > = > (Updated Sept. 23, 2011, 4:20 p.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > hello, > = > I was looking at the projectmanager.projectmanager.[h/cpp] and i noticed = that there wasn't no destructor. > The patch adds a destructor at projectmanager and changed a bit the mainw= indow.cpp. > = > I have some question in my next reply > = > = > Diffs > ----- > = > mainwindow.cpp 3199f03 = > previewer/plasmoid/previewcontainment.cpp 7983cdf = > previewer/runner/runnerpreviewer.cpp 84c6268 = > projectmanager/projectmanager.h a99b14f = > projectmanager/projectmanager.cpp c9c3797 = > publisher/publisher.cpp 211b4e6 = > publisher/signingwidget.h ce40d56 = > publisher/signingwidget.cpp a4ff7a8 = > savesystem/branchdialog.cpp c8a2482 = > sidebar.cpp c9b9318 = > = > Diff: http://git.reviewboard.kde.org/r/101916/diff/diff > = > = > Testing > ------- > = > compiles fine and no pointer error > = > = > Thanks, > = > Giorgos Tsiapaliwkas > = > --===============7723719746357362663== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/101916/

Ship it!

Ship It!
 








- Aaron J.




On September 23rd, 2011, 4:20 p.m., Giorgos Tsiapaliwkas wrote:







 
  

Review request for Plasma.
By Giorgos Tsiapaliwkas.


Updated Sept. 23, 2011, 4:20 p.m.






Descripti=
on 
 
 
  
   hello,

I was looking at the projectmanager.projectmanager.[h/cpp] and i noticed th=
at there wasn't no destructor.
The patch adds a destructor at projectmanager and changed a bit the mainwin=
dow.cpp.

I have some question in my next reply
  
 



Testing <=
/h1>

 
  
   compiles fine and no pointer error
  
 





Diffs=
 


 mainwindow.cpp (3199f03)

 previewer/plasmoid/previewcontainment.cpp =
(7983cdf)

 previewer/runner/runnerpreviewer.cpp (84c6=
268)

 projectmanager/projectmanager.h (a99b14f)<=
/span>

 projectmanager/projectmanager.cpp (c9c3797=
)

 publisher/publisher.cpp (211b4e6)

 
publisher/signingwidget.h (ce40d56)=


 publisher/signingwidget.cpp (a4ff7a8)

 savesystem/branchdialog.cpp (c8a2482)

 sidebar.cpp (c9b9318)



View Diff

--===============7723719746357362663==-- --===============8040795115925397665== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8040795115925397665==--