From kde-panel-devel Fri Sep 30 06:26:24 2011 From: "Aaron J. Seigo" Date: Fri, 30 Sep 2011 06:26:24 +0000 To: kde-panel-devel Subject: Re: Review Request: Remove waste setTextBackgroundColor for internal Message-Id: <20110930062624.28788.26847 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=131736400907297 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2915636506007930320==" --===============2915636506007930320== Content-Type: multipart/alternative; boundary="===============6976754819178208476==" --===============6976754819178208476== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102698/#review6939 ----------------------------------------------------------- Ship it! Ship It! - Aaron J. Seigo On Sept. 30, 2011, 6:25 a.m., Alexey Chernov wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102698/ > ----------------------------------------------------------- > = > (Updated Sept. 30, 2011, 6:25 a.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > Removed setTextBackgroundColor() for internal KTextEdit in Plasma::TextEd= it widget. > = > It seems to be useless as it's voided by inherited QTextDocument as soon = as all the contents of the TextEdit is removed (even with Backspace key). T= he problem is that it also leads to QTBUG-21522 (http://bugreports.qt.nokia= .com/browse/QTBUG-21522) which I mentioned in kde-devel mailing-list under = 'Plasma::TextEdit problem because of QTextEdit::toHtml() bug' subject. I've= sent a patch for that bug, too, but it's probably not good to have any was= te functionality in Plasma itself. > = > If there were some serious reasons to add this string, please, note them = here. Otherwise, I think it's worth to be removed. > = > = > Diffs > ----- > = > plasma/widgets/textedit.cpp 13cc6aa = > = > Diff: http://git.reviewboard.kde.org/r/102698/diff/diff > = > = > Testing > ------- > = > The behavior is the same when used in plasmoids except mentioned Qt bug i= sn't reproducible anymore. > = > = > Thanks, > = > Alexey Chernov > = > --===============6976754819178208476== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102698/

Ship it!

Ship It!
 









- Aaron J.






On September 30th, 2011, 6:25 a.m., Alexey Chernov wrote:









 

  


Review request for Plasma.


By Alexey Chernov.




Updated Sept. 30, 2011, 6:25 a.m.








Descripti=
on 

 

 

  
   
Removed setTextBackgroundColor() for internal KTextEdit in P=
lasma::TextEdit widget.

It seems to be useless as it's voided by inherited QTextDocument as soo=
n as all the contents of the TextEdit is removed (even with Backspace key).=
 The problem is that it also leads to QTBUG-21522 (http://bugreports.qt.nok=
ia.com/browse/QTBUG-21522) which I mentioned in kde-devel mailing-list unde=
r 'Plasma::TextEdit problem because of QTextEdit::toHtml() bug' sub=
ject. I've sent a patch for that bug, too, but it's probably not go=
od to have any waste functionality in Plasma itself.

If there were some serious reasons to add this string, please, note them he=
re. Otherwise, I think it's worth to be removed.

  		
 






Testing <=
/h1>


 

  
   
The behavior is the same when used in plasmoids except menti=
oned Qt bug isn't reproducible anymore.

  		
 








Diffs=
 


    

 
  • plasma/widgets/textedit.cpp (13cc6aa)
    • 





View Diff
--===============6976754819178208476==-- --===============2915636506007930320== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2915636506007930320==--