[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Remove waste setTextBackgroundColor for internal
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-09-30 6:25:29
Message-ID: 20110930062529.28683.19896 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102698/
-----------------------------------------------------------
(Updated Sept. 30, 2011, 6:25 a.m.)
Review request for Plasma.
Changes
-------
correct group
Description
-------
Removed setTextBackgroundColor() for internal KTextEdit in Plasma::TextEdit=
widget.
It seems to be useless as it's voided by inherited QTextDocument as soon as=
all the contents of the TextEdit is removed (even with Backspace key). The=
problem is that it also leads to QTBUG-21522 (http://bugreports.qt.nokia.c=
om/browse/QTBUG-21522) which I mentioned in kde-devel mailing-list under 'P=
lasma::TextEdit problem because of QTextEdit::toHtml() bug' subject. I've s=
ent a patch for that bug, too, but it's probably not good to have any waste=
functionality in Plasma itself.
If there were some serious reasons to add this string, please, note them he=
re. Otherwise, I think it's worth to be removed.
Diffs
-----
plasma/widgets/textedit.cpp 13cc6aa =
Diff: http://git.reviewboard.kde.org/r/102698/diff/diff
Testing
-------
The behavior is the same when used in plasmoids except mentioned Qt bug isn=
't reproducible anymore.
Thanks,
Alexey Chernov
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102698/">http://git.reviewboard.kde.org/r/102698/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Alexey Chernov.</div>
<p style="color: grey;"><i>Updated Sept. 30, 2011, 6:25 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">correct group</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Removed setTextBackgroundColor() for internal KTextEdit in \
Plasma::TextEdit widget.
It seems to be useless as it's voided by inherited QTextDocument as soon as all \
the contents of the TextEdit is removed (even with Backspace key). The problem is \
that it also leads to QTBUG-21522 (http://bugreports.qt.nokia.com/browse/QTBUG-21522) \
which I mentioned in kde-devel mailing-list under 'Plasma::TextEdit problem \
because of QTextEdit::toHtml() bug' subject. I've sent a patch for that bug, \
too, but it's probably not good to have any waste functionality in Plasma itself.
If there were some serious reasons to add this string, please, note them here. \
Otherwise, I think it's worth to be removed.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The behavior is the same when used in plasmoids except mentioned Qt bug \
isn't reproducible anymore.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/widgets/textedit.cpp <span style="color: grey">(13cc6aa)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102698/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic