'Re: Review Request: Bugfix: Plasma::PackageMetadata::read: Match the'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Bugfix: Plasma::PackageMetadata::read: Match the
From:       "Kevin Kofler" <kevin.kofler () chello ! at>
Date:       2011-09-29 21:53:48
Message-ID: 20110929215348.25764.96480 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102404/#review6930
-----------------------------------------------------------

Ping? Can I commit this bugfix to the KDE/4.7 branch?

- Kevin Kofler

On Aug. 22, 2011, 12:49 a.m., Kevin Kofler wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102404/
> -----------------------------------------------------------
> =

> (Updated Aug. 22, 2011, 12:49 a.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Description
> -------
> =

> Also delete the duplicate entries in PackageMetadata::write.
> =

> =

> This one is a bugfix, and so should be OK for 4.7.
> =

> While testing my GSoC work, I noticed that Plasma::PackageMetadata::read =
only looks for X-KDE-ServiceTypes, whereas KService concatenates the conten=
ts of ServiceTypes and X-KDE-ServiceTypes. There are metadata.desktop files=
 out there using ServiceTypes without the X-KDE prefix.
> =

> I also fixed it to look for both Keywords and X-KDE-Keywords as KService =
does, not just Keywords.
> =

> =

> Diffs
> -----
> =

>   plasma/packagemetadata.cpp 59163b2 =

> =

> Diff: http://git.reviewboard.kde.org/r/102404/diff/diff
> =

> =

> Testing
> -------
> =

> Compiles on Fedora 15.
> =

> =

> Thanks,
> =

> Kevin Kofler
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102404/">http://git.reviewboard.kde.org/r/102404/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ping? Can I commit this \
bugfix to the KDE/4.7 branch?</pre>  <br />

<p>- Kevin</p>

<br />
<p>On August 22nd, 2011, 12:49 a.m., Kevin Kofler wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kevin Kofler.</div>

<p style="color: grey;"><i>Updated Aug. 22, 2011, 12:49 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Also delete the duplicate entries in PackageMetadata::write.

This one is a bugfix, and so should be OK for 4.7.

While testing my GSoC work, I noticed that Plasma::PackageMetadata::read only looks \
for X-KDE-ServiceTypes, whereas KService concatenates the contents of ServiceTypes \
and X-KDE-ServiceTypes. There are metadata.desktop files out there using ServiceTypes \
without the X-KDE prefix.

I also fixed it to look for both Keywords and X-KDE-Keywords as KService does, not \
just Keywords.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles on Fedora 15.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/packagemetadata.cpp <span style="color: grey">(59163b2)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102404/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 