[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Bug fix for 278765
From: "Giorgos Tsiapaliwkas" <terietor () gmail ! com>
Date: 2011-09-29 10:39:33
Message-ID: 20110929103933.14237.75469 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102304/
-----------------------------------------------------------
(Updated Sept. 29, 2011, 10:39 a.m.)
Review request for Plasma and Aaron J. Seigo.
Changes
-------
I have added some more flow controls.How can i change the timeout from 0 to \
something?
Description
-------
hello,
I found a third solution for this bug(Aaron said the other two at tha \
plasma-devel mailing list).
This addresses bug 278765.
http://bugs.kde.org/show_bug.cgi?id=278765
Diffs (updated)
-----
plasma/desktop/applets/tasks/abstracttaskitem.cpp 91e9064
plasma/desktop/applets/tasks/applauncheritem.cpp 4dc24ee
plasma/desktop/applets/tasks/taskgroupitem.cpp 5c0540a
plasma/desktop/applets/tasks/windowtaskitem.cpp a782063
Diff: http://git.reviewboard.kde.org/r/102304/diff/diff
Testing
-------
compiles fines
Thanks,
Giorgos Tsiapaliwkas
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102304/">http://git.reviewboard.kde.org/r/102304/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated Sept. 29, 2011, 10:39 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: \
1.5em;">Changes</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have added some more flow controls.How can i change the \
timeout from 0 to something?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">hello,
I found a third solution for this bug(Aaron said the other two at tha \
plasma-devel mailing list).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiles fines</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=278765">278765</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/tasks/abstracttaskitem.cpp <span style="color: \
grey">(91e9064)</span></li>
<li>plasma/desktop/applets/tasks/applauncheritem.cpp <span style="color: \
grey">(4dc24ee)</span></li>
<li>plasma/desktop/applets/tasks/taskgroupitem.cpp <span style="color: \
grey">(5c0540a)</span></li>
<li>plasma/desktop/applets/tasks/windowtaskitem.cpp <span style="color: \
grey">(a782063)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102304/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic