This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102350/

Review request for Plasma.

By Kevin Kofler.

Updated Sept. 27, 2011, 11:38 p.m.

Changes

plasma-dataengine-depextractor:
* Autodetect the API/language used instead of requiring a command-line argu=
ment (and silently assuming C++ when it is not provided).
* Dropped the now unnecessary --api flag. (I can't find anybody using t=
he plasma-dataengine-depextractor yet, but if you do, please just remove th=
e "-a language" or "--api language" parameter.)

Descripti= on

For packages in scripting languages and distributed through =
OCS, this is fully
automatic and triggered from Package::installPackage. If an
X-Plasma-RequiredDataEngines entry is present in the .desktop file (even if
empty), the dependency extraction is not run and the explicitly provided
information is trusted instead.

For native distribution packages, we ship a tool called
plasma-dataengine-depextractor which can be run at any time during the build
process and which adds the dependency information to the relevant .desktop =
file.

Authors of plasmoids are encouraged to run plasma-dataengine-depextractor a=
nd/or
fill in X-Plasma-RequiredDataEngines manually. (Please note that the list is
expected to be comma-separated.)

This is the final portion of my GSoC 2011 project.

Testing <= /h1>

Compiles on Fedora 15.

Tested plasma-dataengine-depextractor on the weather plasmoid, it detected =
the dependency on the weather dataengine correctly and wrote a valid X-Plas=
ma-RequiredDataEngines entry into the .desktop file.

Diffs= (updated)

plasma/CMakeLists.txt (f929967)
plasma/depextractor/depextractor.cpp (PRE-= CREATION)
plasma/package.cpp (4c00d36)
plasma/private/componentinstaller.cpp (870= 667f)
plasma/private/componentinstaller_p.h (f85= cbb6)

View Diff

Descripti= on

Testing <= /h1> Compiles on Fedora 15. Tested plasma-dataengine-depextractor on the weather plasmoid, it detected = the dependency on the weather dataengine correctly and wrote a valid X-Plas= ma-RequiredDataEngines entry into the .desktop file.

Diffs= (updated)

Testing <= /h1>

Compiles on Fedora 15. Tested plasma-dataengine-depextractor on the weather plasmoid, it detected = the dependency on the weather dataengine correctly and wrote a valid X-Plas= ma-RequiredDataEngines entry into the .desktop file.