'Re: Review Request: Implement automatic scanning of source code for'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Implement automatic scanning of source code for
From:       "Kevin Kofler" <kevin.kofler () chello ! at>
Date:       2011-09-27 23:01:03
Message-ID: 20110927230103.31275.33692 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102350/
-----------------------------------------------------------

(Updated Sept. 27, 2011, 11:01 p.m.)

Review request for Plasma.

Changes
-------

* Added support for declarativeappletscript QML code (tested on telepathy-k=
de-presence-applet).
* plasma-dataengine-depextractor: Make sure we pass an absolute path to KDe=
sktopFile (use QDir::absoluteFilePath instead of QDir::filePath), because r=
elative paths are interpreted as relative to applnk rather than to the curr=
ent directory.

Description
-------

For packages in scripting languages and distributed through OCS, this is fu=
lly
automatic and triggered from Package::installPackage. If an
X-Plasma-RequiredDataEngines entry is present in the .desktop file (even if
empty), the dependency extraction is not run and the explicitly provided
information is trusted instead.

For native distribution packages, we ship a tool called
plasma-dataengine-depextractor which can be run at any time during the build
process and which adds the dependency information to the relevant .desktop =
file.

Authors of plasmoids are encouraged to run plasma-dataengine-depextractor a=
nd/or
fill in X-Plasma-RequiredDataEngines manually. (Please note that the list is
expected to be comma-separated.)

This is the final portion of my GSoC 2011 project.

Diffs (updated)
-----

  plasma/CMakeLists.txt f929967 =

  plasma/depextractor/depextractor.cpp PRE-CREATION =

  plasma/package.cpp 4c00d36 =

  plasma/private/componentinstaller.cpp 870667f =

  plasma/private/componentinstaller_p.h f85cbb6 =

Diff: http://git.reviewboard.kde.org/r/102350/diff/diff

Testing
-------

Compiles on Fedora 15.

Tested plasma-dataengine-depextractor on the weather plasmoid, it detected =
the dependency on the weather dataengine correctly and wrote a valid X-Plas=
ma-RequiredDataEngines entry into the .desktop file.

Thanks,

Kevin Kofler

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102350/">http://git.reviewboard.kde.org/r/102350/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kevin Kofler.</div>

<p style="color: grey;"><i>Updated Sept. 27, 2011, 11:01 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* Added support for declarativeappletscript QML code (tested on \
                telepathy-kde-presence-applet).
* plasma-dataengine-depextractor: Make sure we pass an absolute path to KDesktopFile \
(use QDir::absoluteFilePath instead of QDir::filePath), because relative paths are \
interpreted as relative to applnk rather than to the current directory.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For packages in scripting languages and distributed through OCS, this is \
fully automatic and triggered from Package::installPackage. If an
X-Plasma-RequiredDataEngines entry is present in the .desktop file (even if
empty), the dependency extraction is not run and the explicitly provided
information is trusted instead.

For native distribution packages, we ship a tool called
plasma-dataengine-depextractor which can be run at any time during the build
process and which adds the dependency information to the relevant .desktop file.

Authors of plasmoids are encouraged to run plasma-dataengine-depextractor and/or
fill in X-Plasma-RequiredDataEngines manually. (Please note that the list is
expected to be comma-separated.)

This is the final portion of my GSoC 2011 project.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles on Fedora 15.

Tested plasma-dataengine-depextractor on the weather plasmoid, it detected the \
dependency on the weather dataengine correctly and wrote a valid \
X-Plasma-RequiredDataEngines entry into the .desktop file.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/CMakeLists.txt <span style="color: grey">(f929967)</span></li>

 <li>plasma/depextractor/depextractor.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plasma/package.cpp <span style="color: grey">(4c00d36)</span></li>

 <li>plasma/private/componentinstaller.cpp <span style="color: \
grey">(870667f)</span></li>

 <li>plasma/private/componentinstaller_p.h <span style="color: \
grey">(f85cbb6)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102350/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 