[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request: Standard Actions KCM: Hide global column,
From: "Ralf Jung" <ralfjung-e () gmx ! de>
Date: 2011-09-26 15:50:55
Message-ID: 20110926155055.9203.52311 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102709/
-----------------------------------------------------------
Review request for Plasma.
Description
-------
This patch attempts to fix https://bugs.kde.org/show_bug.cgi?id=245603 . It also fixes the problem that \
the action group had the title "Unknown" by setting it manually. The same string also appears at the \
beginning of StandardActionsModule::StandardActionsModule - does that mean it can be backported?
I hope I added the right people as reviewers... I could not find a kde-workspace group and was told in \
IRC that plasma mostly deals with that.
This addresses bug 245603.
http://bugs.kde.org/show_bug.cgi?id=245603
Diffs
-----
kcontrol/standard_actions/standard_actions_module.cpp f1bd45d
Diff: http://git.reviewboard.kde.org/r/102709/diff/diff
Testing
-------
Compile-tested, logged in and verified that the column indeed disappeared and the group name was fixed.
Thanks,
Ralf Jung
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102709/">http://git.reviewboard.kde.org/r/102709/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Ralf Jung.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch attempts to fix \
https://bugs.kde.org/show_bug.cgi?id=245603 . It also fixes the problem that the action group had the \
title "Unknown" by setting it manually. The same string also appears at the beginning of \
StandardActionsModule::StandardActionsModule - does that mean it can be backported?
I hope I added the right people as reviewers... I could not find a kde-workspace group and was told in \
IRC that plasma mostly deals with that.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compile-tested, logged in and verified that \
the column indeed disappeared and the group name was fixed.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=245603">245603</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/standard_actions/standard_actions_module.cpp <span style="color: \
grey">(f1bd45d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102709/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic