'Re: Review Request: Plasmate now supports the "save" action'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Plasmate now supports the "save" action
From:       "Giorgos Tsiapaliwkas" <terietor () gmail ! com>
Date:       2011-09-26 13:08:39
Message-ID: 20110926130839.28839.48199 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Sept. 26, 2011, 12:16 p.m., Aaron J. Seigo wrote:
> > not having a Save function is a _feature_ of plasmate. you just work un=
til you're ready to make a savepoint. all other saving needs are done for y=
ou transparently. why should the user need to worry about saving their work=
 when it can (and is) done automatically for them?

I see what you mean.I understand it now because we have a bug.
If you close the plasmate then all your work will be saved.But if you close=
 the project then your work will not be saved.
I guess that i have to fix the close project function.Correct?

- Giorgos

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102692/#review6826
-----------------------------------------------------------

On Sept. 24, 2011, 8:07 p.m., Giorgos Tsiapaliwkas wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102692/
> -----------------------------------------------------------
> =

> (Updated Sept. 24, 2011, 8:07 p.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Description
> -------
> =

> Hello,
> =

> until now plasmate wasn't able to save a project with the transitional wa=
y.
> This patch adds this functionality
> =

> =

> Diffs
> -----
> =

>   mainwindow.h 1b1c2a2 =

>   mainwindow.cpp 3199f03 =

>   plasmateui.rc 9123298 =

> =

> Diff: http://git.reviewboard.kde.org/r/102692/diff/diff
> =

> =

> Testing
> -------
> =

> working
> =

> =

> Thanks,
> =

> Giorgos Tsiapaliwkas
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102692/">http://git.reviewboard.kde.org/r/102692/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On September 26th, 2011, 12:16 p.m., <b>Aaron J. \
Seigo</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">not having a Save function is a _feature_ of plasmate. you just work \
until you&#39;re ready to make a savepoint. all other saving needs are done for you \
transparently. why should the user need to worry about saving their work when it can \
(and is) done automatically for them?</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see what you mean.I \
understand it now because we have a bug. If you close the plasmate then all your work \
will be saved.But if you close the project then your work will not be saved. I guess \
that i have to fix the close project function.Correct?</pre> <br />

<p>- Giorgos</p>

<br />
<p>On September 24th, 2011, 8:07 p.m., Giorgos Tsiapaliwkas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>

<p style="color: grey;"><i>Updated Sept. 24, 2011, 8:07 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,

until now plasmate wasn&#39;t able to save a project with the transitional way.
This patch adds this functionality</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">working</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>mainwindow.h <span style="color: grey">(1b1c2a2)</span></li>

 <li>mainwindow.cpp <span style="color: grey">(3199f03)</span></li>

 <li>plasmateui.rc <span style="color: grey">(9123298)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102692/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 