From kde-panel-devel Sat Sep 24 12:28:14 2011 From: "Antonis Tsiapaliokas" Date: Sat, 24 Sep 2011 12:28:14 +0000 To: kde-panel-devel Subject: Re: Review Request: Plasmate: Metadata is now able to detect the Message-Id: <20110924122814.25404.10009 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=131686731701453 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2085317798369850789==" --===============2085317798369850789== Content-Type: multipart/alternative; boundary="===============1565968692976151214==" --===============1565968692976151214== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102609/ ----------------------------------------------------------- (Updated Sept. 24, 2011, 12:28 p.m.) Review request for Plasma. Changes ------- Hello I have update my patch. The only thing that has been left to be done is to = add a method in the editpage or in the mainwindow, which when the api is go= ing to be changed, then the .plasmateprojectrc will be updated. Unfortunate= ly i don't know how to call the view->api_combo inside from the metadataedi= tor.cpp. Is this possible? = Summary ------- Hello In the toolbar files, there is a menu with name metadata, which is responsi= ble to retrieve/write some information to the metadata.desktop file. Write = now the plasmate cannot detect the correct api. This patch is fixing this= issue. Diffs (updated) ----- editors/metadata/metadata.ui 454643e = editors/metadata/metadataeditor.h f0ae30c = editors/metadata/metadataeditor.cpp 2b9f89c = mainwindow.h 1b1c2a2 = mainwindow.cpp 3199f03 = startpage.h 5a4a5c8 = startpage.cpp 859d346 = Diff: http://git.reviewboard.kde.org/r/102609/diff Testing ------- Plasmate compiles fines. The only thing that has been left, is to add "the correct" QLabel to metada= ta menu. Thanks, Antonis --===============1565968692976151214== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102609/

Review request for Plasma.

By Antonis Tsiapaliokas.

Updated Sept. 24, 2011, 12:28 p.m.

Changes

Hello

I have update my patch. The only thing that has been left to be done is to =
add a method in the editpage or in the mainwindow, which when the api is go=
ing to be changed, then the .plasmateprojectrc will be updated. Unfortunate=
ly i don't know how to call the view->api_combo inside from the meta=
dataeditor.cpp. Is this possible?

Descripti= on

Hello

In the toolbar files, there is a menu with name metadata, which is responsi=
ble to retrieve/write some information to the metadata.desktop file. Write =
now the plasmate cannot detect the correct api. This  patch is fixing  this=
 issue.

Testing <= /h1>

Plasmate compiles fines.
The only thing that has been left, is to add "the correct" QLabel=
 to metadata menu.

Diffs= (updated)

editors/metadata/metadata.ui (454643e)
editors/metadata/metadataeditor.h (f0ae30c= )
editors/metadata/metadataeditor.cpp (2b9f8= 9c)
mainwindow.h (1b1c2a2)
mainwindow.cpp (3199f03)
startpage.h (5a4a5c8)
startpage.cpp (859d346)

--===============1565968692976151214==-- --===============2085317798369850789== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2085317798369850789==--