[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate:add a destructor and some changes to the
From: "Giorgos Tsiapaliwkas" <terietor () gmail ! com>
Date: 2011-09-23 16:20:57
Message-ID: 20110923162057.10944.45562 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101916/
-----------------------------------------------------------
(Updated Sept. 23, 2011, 4:20 p.m.)
Review request for Plasma.
Changes
-------
sorry for delay and for my absence but i had to study for my university exa=
ms..
This is the complete version of my patch in which i try to fix all the memo=
ry issues that i found
Summary
-------
hello,
I was looking at the projectmanager.projectmanager.[h/cpp] and i noticed th=
at there wasn't no destructor.
The patch adds a destructor at projectmanager and changed a bit the mainwin=
dow.cpp.
I have some question in my next reply
Diffs (updated)
-----
mainwindow.cpp 3199f03 =
previewer/plasmoid/previewcontainment.cpp 7983cdf =
previewer/runner/runnerpreviewer.cpp 84c6268 =
projectmanager/projectmanager.h a99b14f =
projectmanager/projectmanager.cpp c9c3797 =
publisher/publisher.cpp 211b4e6 =
publisher/signingwidget.h ce40d56 =
publisher/signingwidget.cpp a4ff7a8 =
savesystem/branchdialog.cpp c8a2482 =
sidebar.cpp c9b9318 =
Diff: http://git.reviewboard.kde.org/r/101916/diff
Testing
-------
compiles fine and no pointer error
Thanks,
Giorgos
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101916/">http://git.reviewboard.kde.org/r/101916/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated Sept. 23, 2011, 4:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">sorry for delay and for my absence but i had to study for my university \
exams.. This is the complete version of my patch in which i try to fix all the memory \
issues that i found</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">hello,
I was looking at the projectmanager.projectmanager.[h/cpp] and i noticed that there \
wasn't no destructor. The patch adds a destructor at projectmanager and changed a \
bit the mainwindow.cpp.
I have some question in my next reply</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiles fine and no pointer error</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>mainwindow.cpp <span style="color: grey">(3199f03)</span></li>
<li>previewer/plasmoid/previewcontainment.cpp <span style="color: \
grey">(7983cdf)</span></li>
<li>previewer/runner/runnerpreviewer.cpp <span style="color: \
grey">(84c6268)</span></li>
<li>projectmanager/projectmanager.h <span style="color: grey">(a99b14f)</span></li>
<li>projectmanager/projectmanager.cpp <span style="color: \
grey">(c9c3797)</span></li>
<li>publisher/publisher.cpp <span style="color: grey">(211b4e6)</span></li>
<li>publisher/signingwidget.h <span style="color: grey">(ce40d56)</span></li>
<li>publisher/signingwidget.cpp <span style="color: grey">(a4ff7a8)</span></li>
<li>savesystem/branchdialog.cpp <span style="color: grey">(c8a2482)</span></li>
<li>sidebar.cpp <span style="color: grey">(c9b9318)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101916/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic