[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: do not split the year in the clock tip
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-09-23 11:40:32
Message-ID: 20110923114032.27321.75549 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Sept. 23, 2011, 11:37 a.m., Commit Hook wrote:
> > This review has been submitted with commit \
> > 1f068490c0b431ff05f1965c91e5d06d7ae3b7f6 by Aaron Seigo to branch master.
the patch i committed is significantly different than the one in this review, but the \
committed patch was motivated/inspired by the submitted patch. the layout no longer \
tries to show the date very every city and instead groups the cities by date. this \
has a few nice side effects in addition to avoiding the wrapping issue: it shows less \
duplicated data, keeps each city in one row, sorts timezones by their time and puts \
the date at the top which is often the most useful bit of immediate info as in the \
default configuration we don't show the date on the clock itself.
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102621/#review6762
-----------------------------------------------------------
On Sept. 21, 2011, 7:57 p.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102621/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2011, 7:57 p.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> The third verion of this patch does:
> * Shows the city, UTC displacement, and time in one line and the date (I hope \
> English people say "on the" where Spanish people say "del día"), in another line, \
> always complete.
> * removes a <table> that makes the rendering harder
> * adds a <br> to include an space between the dates and the event.
>
> Look at the screnshot.
>
> In any case, I think one part of this patch MUST be commited.
> * removes a <table> that makes the rendering harder
> * adds a <br> to include an space between the dates and the event.
> That is, replace
> if (!subText.isEmpty()) {
> subText.prepend("<table>"); subText is never empty as is created with \
> QString("<table>") subText.append("</table>");
> }
> with
> subText.append("</table><br>");
>
> Of course, kwarning() << data; is not there anymore.
>
>
> This addresses bug 260394.
> http://bugs.kde.org/show_bug.cgi?id=260394
>
>
> Diffs
> -----
>
> libs/plasmaclock/clockapplet.cpp b1275af
>
> Diff: http://git.reviewboard.kde.org/r/102621/diff
>
>
> Testing
> -------
>
> Checked with zero, one and several timezones with short and large city names in two \
> machines.
>
> Screenshots
> -----------
>
> version 2
> http://git.reviewboard.kde.org/r/102621/s/262/
> showing also the UTC displacement
> http://git.reviewboard.kde.org/r/102621/s/267/
>
>
> Thanks,
>
> Jaime Torres
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102621/">http://git.reviewboard.kde.org/r/102621/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 23rd, 2011, 11:37 a.m., <b>Commit \
Hook</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This review has been submitted with commit \
1f068490c0b431ff05f1965c91e5d06d7ae3b7f6 by Aaron Seigo to branch master.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the patch i committed is \
significantly different than the one in this review, but the committed patch was \
motivated/inspired by the submitted patch. the layout no longer tries to show the \
date very every city and instead groups the cities by date. this has a few nice side \
effects in addition to avoiding the wrapping issue: it shows less duplicated data, \
keeps each city in one row, sorts timezones by their time and puts the date at the \
top which is often the most useful bit of immediate info as in the default \
configuration we don't show the date on the clock itself.</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On September 21st, 2011, 7:57 p.m., Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Sept. 21, 2011, 7:57 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The third verion of this patch does:
* Shows the city, UTC displacement, and time in one line and the date (I hope English \
people say "on the" where Spanish people say "del día"), in \
another line, always complete.
* removes a <table> that makes the rendering harder
* adds a <br> to include an space between the dates and the event.
Look at the screnshot.
In any case, I think one part of this patch MUST be commited.
* removes a <table> that makes the rendering harder
* adds a <br> to include an space between the dates and the event.
That is, replace
if (!subText.isEmpty()) {
subText.prepend("<table>"); subText is never empty as is \
created with QString("<table>") \
subText.append("</table>"); }
with
subText.append("</table><br>");
Of course, kwarning() << data; is not there anymore.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Checked with zero, one and several timezones with short and large city \
names in two machines.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=260394">260394</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/plasmaclock/clockapplet.cpp <span style="color: grey">(b1275af)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102621/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/102621/s/262/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/09/15/plasma.260394.2_400x100.png" \
style="border: 1px black solid;" alt="version 2" /></a>
<a href="http://git.reviewboard.kde.org/r/102621/s/267/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/09/21/instantanea3_400x100.png" \
style="border: 1px black solid;" alt="showing also the UTC displacement" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic