--===============8779452832169680321== Content-Type: multipart/alternative; boundary="===============9202131863410106753==" --===============9202131863410106753== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Sept. 22, 2011, 5:45 p.m., Thomas Gahr wrote: > > Just tested it and it fixes the issues mentioned in the bug 273102 :) > > Now... I think it might be a little unlikely for me to be a kde-dev and= actually just pushing stuff to the git repo - will you, Christoph of Aaron= do that? I'll comment on bug 273102 as soon as this is commited so it can be closed. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102631/#review6735 ----------------------------------------------------------- On Sept. 16, 2011, 2:10 p.m., Thomas Gahr wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102631/ > ----------------------------------------------------------- > = > (Updated Sept. 16, 2011, 2:10 p.m.) > = > = > Review request for Plasma. > = > = > Summary > ------- > = > KControl/randr: Make changes to the absolute X/Y coordinates of a display= call setConfigDirty and thus enable the "apply" button. > In some situations the absolute X/Y position is the only thing the user n= eeds to change. At the moment you need to make some dummy change (change re= solution back and forth or alike) to enable the "apply" button. This is not= a good user experience. > = > Sorry for the unnecessary whitespace-changes, qt-creator auto-strips unne= cessary space upon saving. If everything else is fine with this patch and a= nybody insists on it I will update the patch dropping these changes. > = > = > Diffs > ----- > = > kcontrol/randr/outputconfig.cpp 38c8386 = > = > Diff: http://git.reviewboard.kde.org/r/102631/diff > = > = > Testing > ------- > = > Backported the patch to kde-workspace sources 4.7.0 used in Fedora's KDE = rpms (i.e. change valueChanged(int) to textChanged(const QString&), built a= new rpm from the patched sources and tested it on my install. Works just a= s expected. I have yet to finish the setup of my kde-devel environment to t= est it on current master. Will keep you updated if it breaks anything. > = > [update] Works fine with current master > = > = > Thanks, > = > Thomas > = > --===============9202131863410106753== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102631/

On September 22nd, 2011, 5:45 p.m., Thomas = Gahr wrote:

Just test=
ed it and it fixes the issues mentioned in the bug 273102 :)
Now... I think it might be a little unlikely for me to be a kde-dev and act=
ually just pushing stuff to the git repo - will you, Christoph of Aaron do =
that?

I'll co=
mment on bug 273102 as soon as this is commited so it can be closed.

- Thomas

On September 16th, 2011, 2:10 p.m., Thomas Gahr wrote:

Review request for Plasma.

By Thomas Gahr.

Updated Sept. 16, 2011, 2:10 p.m.

Descripti= on

KControl/randr: Make changes to the absolute X/Y coordinates=
 of a display call setConfigDirty and thus enable the "apply" but=
ton.
In some situations the absolute X/Y position is the only thing the user nee=
ds to change. At the moment you need to make some dummy change (change reso=
lution back and forth or alike) to enable the "apply" button. Thi=
s is not a good user experience.

Sorry for the unnecessary whitespace-changes, qt-creator auto-strips unnece=
ssary space upon saving. If everything else is fine with this patch and any=
body insists on it I will update the patch dropping these changes.

Testing <= /h1>

Backported the patch to kde-workspace sources 4.7.0 used in =
Fedora's KDE rpms (i.e. change valueChanged(int) to textChanged(const Q=
String&), built a new rpm from the patched sources and tested it on my =
install. Works just as expected. I have yet to finish the setup of my kde-d=
evel environment to test it on current master. Will keep you updated if it =
breaks anything.

[update] Works fine with current master

Diffs=

kcontrol/randr/outputconfig.cpp (38c8386)<= /span>

--===============9202131863410106753==-- --===============8779452832169680321== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8779452832169680321==--