[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: KControl/randr: Make changes to the absolute X/Y
From: "Thomas Gahr" <identity.kde.org () dadommas ! de>
Date: 2011-09-16 14:10:46
Message-ID: 20110916141046.16678.88353 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102631/
-----------------------------------------------------------
(Updated Sept. 16, 2011, 2:10 p.m.)
Review request for Plasma.
Changes
-------
Needed to disconnect & connect the x/y spinboxes in two more places. Not ve=
ry beautiful but due to the lack of q signal saying "the contents have chan=
ged and the change was due to user input" this is the easiest solution I'd =
say.
Summary
-------
KControl/randr: Make changes to the absolute X/Y coordinates of a display c=
all setConfigDirty and thus enable the "apply" button.
In some situations the absolute X/Y position is the only thing the user nee=
ds to change. At the moment you need to make some dummy change (change reso=
lution back and forth or alike) to enable the "apply" button. This is not a=
good user experience.
Sorry for the unnecessary whitespace-changes, qt-creator auto-strips unnece=
ssary space upon saving. If everything else is fine with this patch and any=
body insists on it I will update the patch dropping these changes.
Diffs (updated)
-----
kcontrol/randr/outputconfig.cpp 38c8386 =
Diff: http://git.reviewboard.kde.org/r/102631/diff
Testing (updated)
-------
Backported the patch to kde-workspace sources 4.7.0 used in Fedora's KDE rp=
ms (i.e. change valueChanged(int) to textChanged(const QString&), built a n=
ew rpm from the patched sources and tested it on my install. Works just as =
expected. I have yet to finish the setup of my kde-devel environment to tes=
t it on current master. Will keep you updated if it breaks anything.
[update] Works fine with current master
Thanks,
Thomas
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102631/">http://git.reviewboard.kde.org/r/102631/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Thomas Gahr.</div>
<p style="color: grey;"><i>Updated Sept. 16, 2011, 2:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Needed to disconnect & connect the x/y spinboxes in two more places. \
Not very beautiful but due to the lack of q signal saying "the contents have \
changed and the change was due to user input" this is the easiest solution \
I'd say.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KControl/randr: Make changes to the absolute X/Y coordinates of a \
display call setConfigDirty and thus enable the "apply" button. In some \
situations the absolute X/Y position is the only thing the user needs to change. At \
the moment you need to make some dummy change (change resolution back and forth or \
alike) to enable the "apply" button. This is not a good user experience.
Sorry for the unnecessary whitespace-changes, qt-creator auto-strips unnecessary \
space upon saving. If everything else is fine with this patch and anybody insists on \
it I will update the patch dropping these changes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Backported the patch to kde-workspace sources 4.7.0 used in Fedora's \
KDE rpms (i.e. change valueChanged(int) to textChanged(const QString&), built a \
new rpm from the patched sources and tested it on my install. Works just as expected. \
I have yet to finish the setup of my kde-devel environment to test it on current \
master. Will keep you updated if it breaks anything.
[update] Works fine with current master</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/randr/outputconfig.cpp <span style="color: grey">(38c8386)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102631/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic