[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate: Metadata is now able to detect the
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-09-15 21:46:32
Message-ID: 20110915214632.1864.67922 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Sept. 14, 2011, 10:53 a.m., Aaron J. Seigo wrote:
> > editors/metadata/metadataeditor.cpp, lines 185-187
> > <http://git.reviewboard.kde.org/r/102609/diff/1/?file=36116#file36116line185>
> >
> > cd("..") only works if the project was created by plasmate. if it was imported \
> > from an existing location, the rc file is in the same directory. unfortunate, but \
> > how it is. look for other instances of cd("..") to see how this is worked around \
> > elsewhere.
>
> Antonis Tsiapaliokas wrote:
> I have a better idea. Instead of finding the correct api into the metadataeditor, \
> we can find it on startpage. Because like that if the api is broken, and someone is \
> using the api in another place of plasmate, then his patch will only work if he \
> opens the metadataeditor. Do you think that this is a good idea?
yes, that's a good point :)
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102609/#review6497
-----------------------------------------------------------
On Sept. 14, 2011, 8:31 a.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102609/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2011, 8:31 a.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Hello
>
> In the toolbar files, there is a menu with name metadata, which is responsible to \
> retrieve/write some information to the metadata.desktop file. Write now the \
> plasmate cannot detect the correct api. This patch is fixing this issue.
>
> Diffs
> -----
>
> editors/metadata/metadata.ui 454643e
> editors/metadata/metadataeditor.h f0ae30c
> editors/metadata/metadataeditor.cpp 2b9f89c
> startpage.h 5a4a5c8
> startpage.cpp 4fe287b
>
> Diff: http://git.reviewboard.kde.org/r/102609/diff
>
>
> Testing
> -------
>
> Plasmate compiles fines.
> The only thing that has been left, is to add "the correct" QLabel to metadata menu.
>
>
> Thanks,
>
> Antonis
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102609/">http://git.reviewboard.kde.org/r/102609/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 14th, 2011, 10:53 a.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/102609/diff/1/?file=36116#file36116line185" \
style="color: black; font-weight: bold; text-decoration: \
underline;">editors/metadata/metadataeditor.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
MetaDataEditor::serviceTypeChanged()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">185</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">foreach</span><span class="p">(</span><span class="k">const</span> <span \
class="n">QString</span> <span class="o">&</span><span class="n">api</span><span \
class="p">,</span> <span class="n">apis</span><span class="p">)</span> <span \
class="p">{</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">185</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">KUrl</span> <span \
class="n">path</span><span class="p">(</span><span class="n">filename</span><span \
class="p">);</span><span class="c1">//we store the location of the \
metadata.desktop</span></pre></td> </tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">186</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">api</span> <span \
class="o">==</span> <span class="n">QString</span><span class="p">(</span><span \
class="s">"dashboard"</span><span class="p">))</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">186</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">//since .plasmateprojectrc is located to levels above the \
metadata.desktop, we use the path.cd and path.directory to reach \
it.</span></pre></td> </tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">187</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">apiNames</span><span class="p">.</span><span class="n">append</span><span \
class="p">(</span><span class="s">"Dashboard"</span><span \
class="p">);</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">187</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">path</span><span \
class="p">.</span><span class="n">cd</span><span class="p">(</span><span \
class="s">".."</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">cd("..") only \
works if the project was created by plasmate. if it was imported from an existing \
location, the rc file is in the same directory. unfortunate, but how it is. look for \
other instances of cd("..") to see how this is worked around \
elsewhere.</pre> </blockquote>
<p>On September 15th, 2011, 8:58 a.m., <b>Antonis Tsiapaliokas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have a better idea. \
Instead of finding the correct api into the metadataeditor, we can find it on \
startpage. Because like that if the api is broken, and someone is using the api in \
another place of plasmate, then his patch will only work if he opens the \
metadataeditor. Do you think that this is a good idea?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, \
that's a good point :)</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On September 14th, 2011, 8:31 a.m., Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Sept. 14, 2011, 8:31 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello
In the toolbar files, there is a menu with name metadata, which is responsible to \
retrieve/write some information to the metadata.desktop file. Write now the plasmate \
cannot detect the correct api. This patch is fixing this issue.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Plasmate compiles fines. The only thing that has been left, is to add \
"the correct" QLabel to metadata menu.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>editors/metadata/metadata.ui <span style="color: grey">(454643e)</span></li>
<li>editors/metadata/metadataeditor.h <span style="color: \
grey">(f0ae30c)</span></li>
<li>editors/metadata/metadataeditor.cpp <span style="color: \
grey">(2b9f89c)</span></li>
<li>startpage.h <span style="color: grey">(5a4a5c8)</span></li>
<li>startpage.cpp <span style="color: grey">(4fe287b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102609/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic