'Re: Review Request: plasma_applet_folderview - folder previews on'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: plasma_applet_folderview - folder previews on
From:       "Commit Hook" <null () kde ! org>
Date:       2011-09-05 10:31:46
Message-ID: 20110905103146.8012.71223 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102300/#review6275
-----------------------------------------------------------

This review has been submitted with commit 43e27148af9d5cbcc82d4853d714ca24945fc780 \
by Aaron Seigo to branch master.

- Commit

On Sept. 5, 2011, 9:33 a.m., Greg T wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102300/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2011, 9:33 a.m.)
> 
> 
> Review request for KDE Base Apps and Plasma.
> 
> 
> Summary
> -------
> 
> Hello, this is my attempt to resolve Bug 250703. The diff adds a gui option in the \
> settings dialog which configures the "click to view" option. It was quite fun \
> because most of the time I didn't know what I'm doing :) 
> 
> This addresses bug 250703.
> http://bugs.kde.org/show_bug.cgi?id=250703
> 
> 
> Diffs
> -----
> 
> plasma/applets/folderview/folderview.h 35a0625 
> plasma/applets/folderview/folderview.cpp 6e95c40 
> plasma/applets/folderview/folderviewDisplayConfig.ui 961296d 
> plasma/applets/folderview/iconview.h 4d736c5 
> 
> Diff: http://git.reviewboard.kde.org/r/102300/diff
> 
> 
> Testing
> -------
> 
> it compiles fine on kde 4.6.5 and does also work.
> 
> 
> Thanks,
> 
> Greg
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102300/">http://git.reviewboard.kde.org/r/102300/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 43e27148af9d5cbcc82d4853d714ca24945fc780 by Aaron Seigo to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On September 5th, 2011, 9:33 a.m., Greg T wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Base Apps and Plasma.</div>
<div>By Greg T.</div>

<p style="color: grey;"><i>Updated Sept. 5, 2011, 9:33 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello, this is my attempt to resolve Bug 250703. The diff adds a gui \
option in the settings dialog which configures the &quot;click to view&quot; option. \
It was quite fun because most of the time I didn&#39;t know what I&#39;m doing \
:)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">it compiles fine on kde 4.6.5 and does also work.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=250703">250703</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/applets/folderview/folderview.h <span style="color: \
grey">(35a0625)</span></li>

 <li>plasma/applets/folderview/folderview.cpp <span style="color: \
grey">(6e95c40)</span></li>

 <li>plasma/applets/folderview/folderviewDisplayConfig.ui <span style="color: \
grey">(961296d)</span></li>

 <li>plasma/applets/folderview/iconview.h <span style="color: \
grey">(4d736c5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102300/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 