[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Add scrollbar support for the Web Slice plasmoid
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2011-08-30 12:45:41
Message-ID: 20110830124541.16181.50435 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 29, 2011, 7:34 a.m., Aaron J. Seigo wrote:
> > what is the use case for this?
> > =
> > introducing configuration options that the user must then manage which =
control UI details like which widgets to show are something we try to avoid=
to preserve ease of use and elegance. if there is a real need for scrollba=
rs in this widget, could they be turned on/off automatically instead?
> =
> Javier Llorente wrote:
> Thanks for your feedback, Aaron. =
> Well, if there's some kind of searchbox on a webpage (ie: a dictionar=
y) and you use it, the results of that query probably need a scrollbar.
> Perhaps the scrollbars could be added if the user hasn't entered an e=
lement to show (css) or if the whole webpage is too big to be displayed in =
the plasmoid.
yes, i like the idea of automatic scrollbars. should hopefully be possible.=
..
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102464/#review6120
-----------------------------------------------------------
On Aug. 27, 2011, 7:58 p.m., Javier Llorente wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102464/
> -----------------------------------------------------------
> =
> (Updated Aug. 27, 2011, 7:58 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Summary
> -------
> =
> I have basically added a function to enable/disable the scrollbar on Web =
Slice.
> =
> =
> Diffs
> -----
> =
> applets/webslice/kgraphicswebslice.h dfb60e5b0b3765f8e2324f832f78a1abac=
0db510 =
> applets/webslice/kgraphicswebslice.cpp 6c976a0f8250e11ffb9dc4e85e122433=
f86a073a =
> applets/webslice/kwebslice.cpp c1eb9ea8da64129765ad68044f2b7d038387b08b =
> applets/webslice/plasma/webslice.h fbe12420ea372c6f1b073a4f047a6cbb742c=
c0a0 =
> applets/webslice/plasma/webslice.cpp a1740bfd62dd91401a366a240e83e6b845=
09f81c =
> applets/webslice/plasma/websliceConfig.ui b3ac77608ec66e1be1ebca04488ae=
19318163a75 =
> =
> Diff: http://git.reviewboard.kde.org/r/102464/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Javier
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102464/">http://git.reviewboard.kde.org/r/102464/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 29th, 2011, 7:34 a.m., <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">what is the use case for this?
introducing configuration options that the user must then manage which control UI \
details like which widgets to show are something we try to avoid to preserve ease of \
use and elegance. if there is a real need for scrollbars in this widget, could they \
be turned on/off automatically instead?</pre> </blockquote>
<p>On August 29th, 2011, 6:12 p.m., <b>Javier Llorente</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for your \
feedback, Aaron. Well, if there's some kind of searchbox on a webpage (ie: a \
dictionary) and you use it, the results of that query probably need a scrollbar. \
Perhaps the scrollbars could be added if the user hasn't entered an element to \
show (css) or if the whole webpage is too big to be displayed in the plasmoid.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, i like the idea of \
automatic scrollbars. should hopefully be possible...</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On August 27th, 2011, 7:58 p.m., Javier Llorente wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Javier Llorente.</div>
<p style="color: grey;"><i>Updated Aug. 27, 2011, 7:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have basically added a function to enable/disable the scrollbar on Web \
Slice.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/webslice/kgraphicswebslice.h <span style="color: \
grey">(dfb60e5b0b3765f8e2324f832f78a1abac0db510)</span></li>
<li>applets/webslice/kgraphicswebslice.cpp <span style="color: \
grey">(6c976a0f8250e11ffb9dc4e85e122433f86a073a)</span></li>
<li>applets/webslice/kwebslice.cpp <span style="color: \
grey">(c1eb9ea8da64129765ad68044f2b7d038387b08b)</span></li>
<li>applets/webslice/plasma/webslice.h <span style="color: \
grey">(fbe12420ea372c6f1b073a4f047a6cbb742cc0a0)</span></li>
<li>applets/webslice/plasma/webslice.cpp <span style="color: \
grey">(a1740bfd62dd91401a366a240e83e6b84509f81c)</span></li>
<li>applets/webslice/plasma/websliceConfig.ui <span style="color: \
grey">(b3ac77608ec66e1be1ebca04488ae19318163a75)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102464/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic