From kde-panel-devel Mon Aug 29 10:56:17 2011 From: Kevin Krammer Date: Mon, 29 Aug 2011 10:56:17 +0000 To: kde-panel-devel Subject: Re: Review Request: plasma_applet_folderview - folder previews on Message-Id: <201108291256.22089.kevin.krammer () gmx ! at> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=131461543603016 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8322978334924264407==" --===============8322978334924264407== Content-Type: multipart/signed; boundary="nextPart8180828.yDHxSlA1CS"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit --nextPart8180828.yDHxSlA1CS Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable On Monday, 2011-08-29, Greg T wrote: > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102300/#review6133 > ----------------------------------------------------------- >=20 >=20 > Hey guys, no reaction? this isn't the right place? The Plasma people might have their own reviewboard group, but at least some= of=20 them should be subscribed to kde-core-devel as well. Anyway, CCing plasma-devel Cheers, Kevin >=20 > - Greg >=20 > On Aug. 11, 2011, 9:39 a.m., Greg T wrote: > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > http://git.reviewboard.kde.org/r/102300/ > > ----------------------------------------------------------- > >=20 > > (Updated Aug. 11, 2011, 9:39 a.m.) > >=20 > >=20 > > Review request for KDE Base Apps. > >=20 > >=20 > > Summary > > ------- > >=20 > > Hello, this is my attempt to resolve Bug 250703. The diff adds a gui > > option in the settings dialog which configures the "click to view" > > option. It was quite fun because most of the time I didn't know what I'm > > doing :) > >=20 > >=20 > > This addresses bug 250703. > >=20 > > http://bugs.kde.org/show_bug.cgi?id=3D250703 > >=20 > > Diffs > > ----- > >=20 > > plasma/applets/folderview/folderview.h 35a0625 > > plasma/applets/folderview/folderview.cpp 6e95c40 > > plasma/applets/folderview/folderviewDisplayConfig.ui 961296d > > plasma/applets/folderview/iconview.h 4d736c5 > >=20 > > Diff: http://git.reviewboard.kde.org/r/102300/diff > >=20 > >=20 > > Testing > > ------- > >=20 > > it compiles fine on kde 4.6.5 and does also work. > >=20 > >=20 > > Thanks, > >=20 > > Greg =2D-=20 Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring --nextPart8180828.yDHxSlA1CS Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iD8DBQBOW3BRnKMhG6pzZJIRAtPGAJ47eDoThUwRniPZQYNdL0CPKH8HWgCeMPN3 c7UmgNJP/tkcxZwWOs5AazY= =XMJY -----END PGP SIGNATURE----- --nextPart8180828.yDHxSlA1CS-- --===============8322978334924264407== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8322978334924264407==--