This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102404/

Review request for Plasma.
By Kevin Kofler.

Updated Aug. 22, 2011, 12:49 a.m.

Changes

Also delete the duplicate entries in PackageMetadata::write.

Description (updated)

Also delete the duplicate entries in PackageMetadata::write.


This one is a bugfix, and so should be OK for 4.7.

While testing my GSoC work, I noticed that Plasma::PackageMetadata::read only looks for X-KDE-ServiceTypes, whereas KService concatenates the contents of ServiceTypes and X-KDE-ServiceTypes. There are metadata.desktop files out there using ServiceTypes without the X-KDE prefix.

I also fixed it to look for both Keywords and X-KDE-Keywords as KService does, not just Keywords.

Testing

Compiles on Fedora 15.

Diffs (updated)

  • plasma/packagemetadata.cpp (59163b2)

View Diff