From kde-panel-devel Thu Aug 18 18:09:19 2011 From: "Giorgos Tsiapaliwkas" Date: Thu, 18 Aug 2011 18:09:19 +0000 To: kde-panel-devel Subject: Re: Review Request: Plasmate:migrate timeline.cpp from Q classes to K Message-Id: <20110818180919.15164.11626 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=131369098521736 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0014737851120956965==" --===============0014737851120956965== Content-Type: multipart/alternative; boundary="===============7009034821700468918==" --===============7009034821700468918== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102027/ ----------------------------------------------------------- (Updated Aug. 18, 2011, 6:09 p.m.) Review request for Plasma. Changes ------- i updated the diff. Should i push it? Summary ------- hello, the patch migrates the timeline.cpp from the Q classes to K classes. Also adds a KMessageBox::information in the newsavepoint(),in order to info= rm the user that he can't create a new save point without any changes being= made Diffs (updated) ----- savesystem/timeline.cpp 2ed3ac2 = Diff: http://git.reviewboard.kde.org/r/102027/diff Testing ------- no issues. Thanks, Giorgos --===============7009034821700468918== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102027/

Review request for Plasma.
By Giorgos Tsiapaliwkas.

Updated Aug. 18, 2011, 6:09 p.m.

Changes
i updated the diff.

Should i push it?

Descripti= on

hello,

the patch migrates the timeline.cpp from the Q classes to K classes.
Also adds a KMessageBox::information in the newsavepoint(),in order to info=
rm the user that he can't create a new save point without any changes b=
eing made

Testing <= /h1>
no issues.

Diffs= (updated)

  • savesystem/timeline.cpp (2ed3ac2)

View Diff

--===============7009034821700468918==-- --===============0014737851120956965== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0014737851120956965==--