[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Add a system tray option to always show all items
From: "Jonathan Marten" <jjm () keelhaul ! me ! uk>
Date: 2011-08-05 17:14:51
Message-ID: 20110805171451.12683.56759 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100743/
-----------------------------------------------------------
(Updated Aug. 5, 2011, 5:14 p.m.)
Review request for Plasma.
Changes
-------
Updated the patch to retain the individual items' states as those which can=
be set when the option is off.
So the task's internal state does not need to be changed via setHidden(), a=
nd there is also no change
needed to the logic in TaskArea::checkVisibility().
Summary
-------
If the user wishes to have all system tray items visible at all times, ther=
e is no single setting to allow this. The only option is to go to System T=
ray Settings - Entries and set all of the "Visibility" combo boxes to "Alwa=
ys Visible", and repeat this whenever a new item appears.
All versions of a popular closed source operating system have this option f=
or the system tray.
This change adds a check box "Always show all system tray items" below the =
list on the Entries page. Checking this sets all items (current and any ne=
w ones that may appear in future) to be always visible and disables the "Vi=
sibility" column. It is still possible to access the "Keyboard Shortcut" c=
olumn.
The default is for this option not to be set, so the system tray operation =
is the same as before.
Diffs (updated)
-----
plasma/generic/applets/systemtray/ui/applet.h d6cc509 =
plasma/generic/applets/systemtray/ui/applet.cpp f3c6d9a =
plasma/generic/applets/systemtray/ui/autohide.ui 3b6efff =
plasma/generic/applets/systemtray/ui/taskarea.h 9a47d16 =
plasma/generic/applets/systemtray/ui/taskarea.cpp f47515f =
Diff: http://git.reviewboard.kde.org/r/100743/diff
Testing
-------
Built kde-workspace with these changes, checked operation of system tray an=
d settings dialogue with this option checked and not checked.
Thanks,
Jonathan
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100743/">http://git.reviewboard.kde.org/r/100743/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jonathan Marten.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2011, 5:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Updated the patch to retain the individual items' states as those \
which can be set when the option is off. So the task's internal state does not \
need to be changed via setHidden(), and there is also no change needed to the logic \
in TaskArea::checkVisibility().</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If the user wishes to have all system tray items visible at all times, \
there is no single setting to allow this. The only option is to go to System Tray \
Settings - Entries and set all of the "Visibility" combo boxes to \
"Always Visible", and repeat this whenever a new item appears.
All versions of a popular closed source operating system have this option for the \
system tray.
This change adds a check box "Always show all system tray items" below the \
list on the Entries page. Checking this sets all items (current and any new ones \
that may appear in future) to be always visible and disables the \
"Visibility" column. It is still possible to access the "Keyboard \
Shortcut" column.
The default is for this option not to be set, so the system tray operation is the \
same as before.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built kde-workspace with these changes, checked operation of system tray \
and settings dialogue with this option checked and not checked. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/systemtray/ui/applet.h <span style="color: \
grey">(d6cc509)</span></li>
<li>plasma/generic/applets/systemtray/ui/applet.cpp <span style="color: \
grey">(f3c6d9a)</span></li>
<li>plasma/generic/applets/systemtray/ui/autohide.ui <span style="color: \
grey">(3b6efff)</span></li>
<li>plasma/generic/applets/systemtray/ui/taskarea.h <span style="color: \
grey">(9a47d16)</span></li>
<li>plasma/generic/applets/systemtray/ui/taskarea.cpp <span style="color: \
grey">(f47515f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100743/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic