'Re: Review Request: Connect to the correct signal'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Connect to the correct signal
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2011-08-03 7:58:57
Message-ID: 20110803075857.20295.8989 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102173/#review5333
-----------------------------------------------------------

Ship it!

nice catch.. thanks :)

this should be applied to both 4.7 and master imho.

- Aaron J.

On Aug. 1, 2011, 11:14 p.m., Albert Astals Cid wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102173/
> -----------------------------------------------------------
> =

> (Updated Aug. 1, 2011, 11:14 p.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Summary
> -------
> =

> The signal parameters are wrong, plasma-desktop complains on startup
> =

> =

> Diffs
> -----
> =

>   plasma/desktop/applets/pager/pager.h c482b21 =

>   plasma/desktop/applets/pager/pager.cpp 588a49d =

> =

> Diff: http://git.reviewboard.kde.org/r/102173/diff
> =

> =

> Testing
> -------
> =

> None
> =

> =

> Thanks,
> =

> Albert
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102173/">http://git.reviewboard.kde.org/r/102173/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">nice catch.. thanks :)

this should be applied to both 4.7 and master imho.</pre>
 <br />

<p>- Aaron J.</p>

<br />
<p>On August 1st, 2011, 11:14 p.m., Albert Astals Cid wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Albert Astals Cid.</div>

<p style="color: grey;"><i>Updated Aug. 1, 2011, 11:14 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The signal parameters are wrong, plasma-desktop complains on \
startup</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">None</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/applets/pager/pager.h <span style="color: \
grey">(c482b21)</span></li>

 <li>plasma/desktop/applets/pager/pager.cpp <span style="color: \
grey">(588a49d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102173/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 