This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102027/ 

the dialog box changes look good. the action changes don't. please commit the dialog changes ...

savesystem/timeline.cpp (Diff revision 2) 
void TimeLine::showContextMenu(QTableWidgetItem *item)
235 
        QAction *restoreCommit = menu.addAction(i18n("Restore SavePoint"));
 231 
        KAction *restoreCommit = new KAction(i18n("Restore SavePoint"), this);
236 
        restoreCommit->setData(QVariant(tlItem->getHash()));
 232 
        restoreCommit->setData(QVariant(tlItem->getHash()));
237 
        QAction *moveToCommit = menu.addAction(i18n("Move to this SavePoint"));
 233 
        menu.addAction(restoreCommit);
 

    234
    
        KAction *moveToCommit =new KAction(i18n("Move to this SavePoint"), this);

  


  

    
    

    235
    
        menu.addAction(moveToCommit);

  


 





 
 

 

  

    238
    
        moveToCommit->setData(QVariant(tlItem->getHash()));

    236
    
        moveToCommit->setData(QVariant(tlItem->getHash()));

  


 


 
 




 

  

    239
    

    237
    
        qDebug() << "level1";

  


 





 
 

 

  

    240
    
        connect(restoreCommit, SIGNAL(triggered(bool)),

    238
    
        connect(restoreCommit, SIGNAL(triggered(bool)),

  


  

    241
    
                this, SLOT(restoreCommit()));

    239
    
                this, SLOT(restoreCommit()));

  


  

    242
    
        connect(moveToCommit, SIGNAL(triggered(bool)),

    240
    
        connect(moveToCommit, SIGNAL(triggered(bool)),

  


  

    243
    
                this, SLOT(moveToCommit()));

    241
    
                this, SLOT(moveToCommit()));

  


  

    244
    
        break;

    242
    
        break;

  


  

    245
    
    }

    243
    
    }

  


  

    246
    
    case TimeLineItem::Branch:

    244
    
    case TimeLineItem::Branch:

  


  

    247
    
    {

    245
    
    {

  


 


 
 




 

  

    248
    
        QAction *createBranch = menu.addAction(i18n("Create new Section"));

    246
    
        KAction *createBranch = new KAction(i18n("Create new Section"), this);

  


  

    249
    
        QMenu *switchBranchMenu = menu.addMenu(i18n("Switch to Section"));

    247
    
        KMenu *switchBranchMenu = new KMenu(i18n("Switch to Section"), this);

  


  

    250
    
        QMenu *mergeBranchMenu = menu.addMenu(i18n("Combine into Section"));

    248
    
        KMenu *mergeBranchMenu = new KMenu(i18n("Combine into Section"), this);

  


  

    251
    
        QAction *renameBranch = menu.addAction(i18n("Rename current Section"));

    249
    
        KAction *renameBranch = new KAction(i18n("Rename current Section"), this);

  


 





 
 

 

  

    252
    
        menu.addSeparator();

    250
    
        menu.addSeparator();

  


 


 
 




 

  

    253
    
        QMenu *deleteBranchMenu = menu.addMenu(i18n("Delete Section"));

    251
    
        KMenu *deleteBranchMenu = new KMenu(i18n("Delete Section"),this);

  


 





again, there is no benefit at all to these changes here. it even makes it more ambiguous who owns the actions and introduces memory management problems.














 
  

   
    savesystem/timeline.cpp
    

     (Diff revision 2)

    
   
  

 

 
  


   
void TimeLine::newSavePoint()


  

 



 
 




 

  

    351
    
    warningMB->setWindowTitle(i18n("Information"));

    349
    
    if (code!=KMessageBox::Continue) {

  


 





needs ws around the !=














 
  

   
    savesystem/timeline.cpp
    

     (Diff revision 2)

    
   
  

 

 
  


   
void TimeLine::newSavePoint()


  

 



 
 




 

  

    374
    
    warningMB->setWindowTitle(i18n("Information"));

    366
    
    if (code!=KMessageBox::Continue) {

  


 





ws missing  here too














 
  

   
    savesystem/timeline.cpp
    

     (Diff revision 2)

    
   
  

 

 
  


   
void TimeLine::newSavePoint()


  

 



 
 




 

  

    405
    
    QAction *sender = dynamic_cast<QAction*>(this->sender());

    385
    
    KAction *sender = qobject_cast<KAction*>(this->sender());

  


 





why?














 
  

   
    savesystem/timeline.cpp
    

     (Diff revision 2)

    
   
  

 

 
  


   
void TimeLine::newSavePoint()


  

 



 
 




 

  

    416
    
    QAction *sender = dynamic_cast<QAction*>(this->sender());

    396
    
    KAction *sender = qobject_cast<KAction*>(this->sender());

  


 





why?














 
  

   
    savesystem/timeline.cpp
    

     (Diff revision 2)

    
   
  

 

 
  


   
void TimeLine::mergeBranch()


  

 



 
 




 

  

    460
    
    QAction *sender = dynamic_cast<QAction*>(this->sender());

    432
    
    KAction *sender = qobject_cast<KAction*>(this->sender());

  


 





why?














 
  

   
    savesystem/timeline.cpp
    

     (Diff revision 2)

    
   
  

 

 
  


   
void TimeLine::mergeBranch()


  

 



 
 




 

  

    501
    
    QAction *sender = dynamic_cast<QAction*>(this->sender());

    465
    
    KAction *sender = qobject_cast<KAction*>(this->sender());

  


 





why?














 
  

   
    savesystem/timeline.cpp
    

     (Diff revision 2)

    
   
  

 

 
  


   
void TimeLine::mergeBranch()


  

 



 
 




 

  

    532
    
    QAction *sender = dynamic_cast<QAction*>(this->sender());

    489
    
    KAction *sender = qobject_cast<KAction*>(this->sender());

  


 





why?









- Aaron J.






On July 24th, 2011, 8:51 p.m., Giorgos Tsiapaliwkas wrote:









 

  


Review request for Plasma.


By Giorgos Tsiapaliwkas.




Updated July 24, 2011, 8:51 p.m.






Description 



 

  
   
hello,

the patch migrates the timeline.cpp from the Q classes to K classes.
Also adds a KMessageBox::information in the newsavepoint(),in order to inform the user that he can't create a new save point without any changes being made

  		
 






Testing 



 

  
   
no issues.

  		
 








Diffs 


    

 
  • savesystem/timeline.cpp (2ed3ac2)
    • 





View Diff