This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/102027/

the dialog=
 box changes look good. the action changes don't. please commit the dia=
log changes ...

= = = = = = = = = = = = = = = = = = = =

savesystem/timeline.cpp (Diff revision 2)
void TimeLine::showContextMenu(QTableWidgetItem *item)
235	Q= Action *restoreCom= mit =3D menu.addAction= (i18n("Restore SavePoint"));	231	K= Action *restoreCom= mit =3D new KAction(i1= 8n("Restore SavePoin= t"), this<= span class=3D"p">);
236	restoreCommit= ->setData(QVariant(<= span class=3D"n">tlItem->getHash()));	232	restoreCommit= ->setData(QVariant(<= span class=3D"n">tlItem->getHash()));
237	QAction *moveToCommit =3D menu.addAction(i18n= ("Move to this SaveP= oint"));	233	menu.addAction(restoreCommit);
		234	KAction *moveToCommit =3Dnew KAction(i18n("Move to this SavePoint"), this);
		235	menu.addAction(moveToCommit);
238	moveToCommit<= span class=3D"o">->setData(QVariant(tlItem->= getHash()));	236	moveToCommit<= span class=3D"o">->setData(QVariant(tlItem->= getHash()));
239		237	qDebug() << &q= uot;level1";
240	connect(restoreCommit, SIGNAL(triggered(bool= )),	238	connect(restoreCommit, SIGNAL(triggered(bool= )),
241	this<= span class=3D"p">, SLOT(<= /span>restoreCommit()));<= /pre>	239	this<= span class=3D"p">, SLOT(<= /span>restoreCommit()));<= /pre>
242	connect(moveToCommit= , SIGNAL(triggered(bool<= /span>)),	240	connect(moveToCommit= , SIGNAL(triggered(bool<= /span>)),
243	this<= span class=3D"p">, SLOT(<= /span>moveToCommit()));	241	this<= span class=3D"p">, SLOT(<= /span>moveToCommit()));
244	break;	242	break;
245	}	243	}
246	case TimeLineItem::Bra= nch:	244	case TimeLineItem::Bra= nch:
247	{	245	{
248	Q= Action *createBran= ch =3D menu.addAction(= i18n("Create new Section"));	246	K= Action *createBran= ch =3D new KAction(i1= 8n("Create new Secti= on"), this= );
249	Q= Menu *switchBranch= Menu =3D menu.addMenu(= i18n("Switch to Section"));	247	K= Menu *switchBranch= Menu =3D new KMenu(i18= n("Switch to Section= "), this);
250	Q= Menu *mergeBranchM= enu =3D menu.addMenu(<= /span>i18n("Combine into Section"));	248	K= Menu *mergeBranchM= enu =3D new KMenu(i18n= ("Combine into Secti= on"), this= );
251	Q= Action *renameBran= ch =3D menu.addAction(= i18n("Rename current Section"));	249	K= Action *renameBran= ch =3D new KAction(i1= 8n("Rename current S= ection"), this);
252	menu.addSeparator();=	250	menu.addSeparator();=
253	Q= Menu *deleteBranch= Menu =3D menu.addMenu(= i18n("Delete Section")); <= /td>	251	K= Menu *deleteBranch= Menu =3D new KMenu(i18= n("Delete Section&qu= ot;),this);

again, there is no benefit at all to these changes here. it even mak=
es it more ambiguous who owns the actions and introduces memory management =
problems.

= =

savesystem/timeline.cpp (Diff revision 2)
void TimeLine::newSavePoint()
351	warningMB->setWindowTitle(i18n("Information")); <= /td>	349	if (code!=3DKMessageBox::Continue) { =

needs ws around the !=3D

= =

savesystem/timeline.cpp (Diff revision 2)
void TimeLine::newSavePoint()
374	warningMB->setWindowTitle(i18n("Information")); <= /td>	366	if (code!=3DKMessageBox::Continue) { =

ws missing  here too

= =

savesystem/timeline.cpp (Diff revision 2)
void TimeLine::newSavePoint()
405	QAction sender = =3D dynamic_cast<QAction>(this->sender());	385	KAction sender = =3D qobject_cast<KAction>(this->sender());

why?

= =

savesystem/timeline.cpp (Diff revision 2)
void TimeLine::newSavePoint()
416	QAction sender = =3D dynamic_cast<QAction>(this->sender());	396	KAction sender = =3D qobject_cast<KAction>(this->sender());

why?

= =

savesystem/timeline.cpp (Diff revision 2)
void TimeLine::mergeBranch()
460	QAction sender = =3D dynamic_cast<QAction>(this->sender());	432	KAction sender = =3D qobject_cast<KAction>(this->sender());

why?

= =

savesystem/timeline.cpp (Diff revision 2)
void TimeLine::mergeBranch()
501	QAction sender = =3D dynamic_cast<QAction>(this->sender());	465	KAction sender = =3D qobject_cast<KAction>(this->sender());

why?

= =

savesystem/timeline.cpp (Diff revision 2)
void TimeLine::mergeBranch()
532	QAction sender = =3D dynamic_cast<QAction>(this->sender());	489	KAction sender = =3D qobject_cast<KAction>(this->sender());

why?

- Aaron J.

On July 24th, 2011, 8:51 p.m., Giorgos Tsiapaliwkas wrote:

Review request for Plasma.

By Giorgos Tsiapaliwkas.

Updated July 24, 2011, 8:51 p.m.

Descripti= on

hello,

the patch migrates the timeline.cpp from the Q classes to K classes.
Also adds a KMessageBox::information in the newsavepoint(),in order to info=
rm the user that he can't create a new save point without any changes b=
eing made

Testing <= /h1>

no issues.

Diffs=

savesystem/timeline.cpp (2ed3ac2)

View Diff